chore: table toolbar simplifications#9296
Merged
AdityaHegde merged 3 commits intomainfrom Apr 27, 2026
Merged
Conversation
AdityaHegde
force-pushed
the
chore/table-toolbar-simplifications
branch
from
57b2c49 to
b5d748e
Compare
AdityaHegde
force-pushed
the
chore/table-toolbar-simplifications
branch
from
b5d748e to
d73e6a0
Compare
djbarnwal
approved these changes
Apr 24, 2026
royendo
added a commit
that referenced
this pull request
Apr 27, 2026
Brings in #9296's table-toolbar simplifications, which moved the toolbar to bindable props (`bind:searchText`, `bind:sortDirection`) and changed `onFilterChange`'s second arg from a single value to the full new selection (the dropdown now performs the toggle internally). - Adopt main's TableToolbar + filter-dropdown + sort APIs. - Re-add `showSearch` and `disabled` props that this branch had previously introduced; propagate `disabled` to `TableToolbarSort` and `TableToolbarFilterDropdown` so empty-data tables disable cleanly. - Migrate the five caller tables (alerts listing, alerts history, reports listing, reports history, dashboards) to the bindable API and rewrite each `handleFilterChange` to consume the new array signature. - Drop the now-unused `toggleArrayValue` helper since the toolbar owns the toggle. - Take main's rewritten `ProjectLogsPage.svelte`, which no longer uses `TableToolbar` (uses `Search` + `DropdownMenu` directly). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
royendo
added a commit
that referenced
this pull request
Apr 27, 2026
Brings in 46 commits from main, most notably: - #8912 Cloud editing MVP: branch deployment selector pill, `@branch` path-segment routing, "Open in editor" affordance. - #9296 Table toolbar simplifications (bindable API, new `onFilterChange(key, selected)` signature). - #9187 Chart type selector in explore (replaces `chart_force_line` proto field with `reserved 36`). Conflicts resolved: - `resource-graph/graph-canvas/ResourceNode.svelte`: kept this branch's refactored node structure (horizontal handles, inspect-store, test-failure marker, loading spinner), and ported main's "Open in editor" affordance — `NodeToolbar` with an `ExternalLink` button shown when a node is selected and resolves to a file artifact. Skipped main's error popover since this branch surfaces errors via the inspect store. Added `.toolbar-open-btn` styles. - `resource-graph/summary/SummaryGraph.svelte` and `summary/SummaryNode.svelte`: kept this branch's deletes (the summary surface was superseded). Main's `branchSearchSuffix` change to those files goes nowhere — the files no longer exist on this branch. - `web-local/.../graph/+page.svelte`: kept this branch's rich implementation. Main's replacement (`<GraphWorkspace />`) is a cloud-only entry point that doesn't fit `web-local`. - `models/navigation/ModelMenuItems.svelte`: combined imports — kept this branch's `resourceShorthandMapping` / `ResourceKind`, added main's `navigateToFile`, restored a missing `goto` import for `viewGraph`. Dropped the unused `openResourceGraphQuickView` import. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
searchText,sortDirectionandviewModeinstead of callbacks to update values.sortDirectionandviewMode.TableToolbarFilterDropdownso that consumers dont have to manually toggle.TableToolbarAppliedFiltersto apply to both addition and deletion.Checklist: