Skip to content

fix: nested measure filter form not submitting#9322

Merged
AdityaHegde merged 2 commits into
mainfrom
fix/nested-measure-filter-form
Apr 28, 2026
Merged

fix: nested measure filter form not submitting#9322
AdityaHegde merged 2 commits into
mainfrom
fix/nested-measure-filter-form

Conversation

@AdityaHegde
Copy link
Copy Markdown
Collaborator

@AdityaHegde AdityaHegde commented Apr 28, 2026

Measure filter dropdown had its own form. Submit button was interfering with alert form preventing measure filter apply within the alert form.

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@AdityaHegde AdityaHegde requested a review from a team as a code owner April 28, 2026 15:52
@AdityaHegde AdityaHegde requested a review from djbarnwal April 28, 2026 15:53
@AdityaHegde AdityaHegde mentioned this pull request Apr 28, 2026
8 tasks
@AdityaHegde AdityaHegde added the blocker A release blocker issue that should be resolved before a new release label Apr 28, 2026
@AdityaHegde AdityaHegde merged commit 2ba36eb into main Apr 28, 2026
14 of 15 checks passed
@AdityaHegde AdityaHegde deleted the fix/nested-measure-filter-form branch April 28, 2026 16:45
AdityaHegde added a commit that referenced this pull request Apr 28, 2026
* fix: nested measure filter form not submitting

* Use formId from superforms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocker A release blocker issue that should be resolved before a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants