feat: add EnvVarName to PropertySpec and annotate driver specs#9323
Closed
royendo wants to merge 1 commit into
Closed
feat: add EnvVarName to PropertySpec and annotate driver specs#9323royendo wants to merge 1 commit into
EnvVarName to PropertySpec and annotate driver specs#9323royendo wants to merge 1 commit into
Conversation
Adds a metadata-only `EnvVarName` field on `drivers.PropertySpec` and populates it on secret properties across athena, azure, bigquery, clickhouse, druid, duckdb (motherduck), gcs, mysql, pinot, postgres, redshift, s3, salesforce, and snowflake. The field captures the conventional env var name (e.g. `AWS_ACCESS_KEY_ID`, `GOOGLE_APPLICATION_CREDENTIALS`) since the mapping isn't mechanical. No consumers yet; field is read by upcoming template-connector work. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
Author
|
So your real question is: do we want the env var convention defined once at the driver level (Go) or per-template (JSON)? Will close for now since the current template code doesnt actually use this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as part of effort to slim: #8981,
EnvVarNamemetadata field todrivers.PropertySpecso driver specs can declare the conventional env var name for each secret property (e.g.AWS_ACCESS_KEY_ID,GOOGLE_APPLICATION_CREDENTIALS).EnvVarNameon secret properties across 14 driver specs:athena,azure,bigquery,clickhouse,druid,duckdb(motherduck),gcs,mysql,pinot,postgres,redshift,s3,salesforce,snowflake.AWS_*), others add infixes (AZURE_STORAGE_*), and some diverge entirely (GCSkey_id→GCP_ACCESS_KEY_ID) — so the field has to be explicit.Checklist:
Developed in collaboration with Claude Code