fix: Vega tooltip parsing for dimension comparison values#9419
Merged
Conversation
AdityaHegde
approved these changes
May 11, 2026
| } | ||
| } | ||
|
|
||
| export function sanitizeTitleForVegaTooltip(value: unknown) { |
Collaborator
There was a problem hiding this comment.
Could you add a small comment describing why we need to sanitise title. Also good to add a similar one for sanitizeValueForVega above as well.
djbarnwal
added a commit
that referenced
this pull request
May 14, 2026
* fix: Vega tooltip parsing for dimension comparison values * add comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes chart rendering errors in Explore dimension comparison mode when selected dimension values contain markdown, newlines, URLs, quotes, or other punctuation.
Changes:
Add safe tooltip titles for pivoted dimension-value tooltip fields instead of reusing Vega-escaped field paths as labels.
Escape quotes in Vega field-path sanitization.
Keep tooltip color mapping aligned with normalized tooltip labels.
https://linear.app/rilldata/issue/ENG-1108/text-leaks-from-tables-into-chart-area-during-comparison
Checklist: