fix: rilltime syntax in comparison time range in citation urls#9478
Merged
AdityaHegde merged 15 commits intoJun 2, 2026
Conversation
AdityaHegde
force-pushed
the
fix/rill-time-comparison-time-in-citation-urls
branch
3 times, most recently
from
d8044db to
4124b7c
Compare
begelundmuller
requested changes
May 29, 2026
Comment on lines
+282
to
+286
| // Resolve time ranges and store them in the result to record the exact resolved time ranges for this tool call | ||
| resolvedTimeRanges, err := t.resolveTimeRanges(ctx, session, args) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
Contributor
There was a problem hiding this comment.
To avoid duplicate logic and execution (timestamps may not always be cached), can we return the time ranges from the metrics resolver (you can use ResolverResult.Meta() map for them), and in turn push it into the executor (which already has the necessary logic, and the timestamps binding ensures no duplicate queries)?
Collaborator
Author
There was a problem hiding this comment.
Ok updated to return the resolved time ranges from metrics resolver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM can use rill time for relative time ranges. Since backend supports it in comparison time range as well, it can use it in comparison as well. But UI doesnt support rill time, leading to removal of comparison all together.
Since watermark history at the time of query is not available, we are opting to resolve the time ranges and store it in the tool result.
Checklist: