move credit alerts to trial start time#9498
Merged
Merged
Conversation
pjain1
added
the
blocker
pjain1
commented
May 24, 2026
Member
Author
There was a problem hiding this comment.
Changes in this file are just some cleanup.
AdityaHegde
reviewed
May 26, 2026
| return fmt.Errorf("creating credit_balance_dropped alert: %w", err) | ||
| for iter.Next() { | ||
| a := iter.Current() | ||
| if a.Currency == currency { |
Collaborator
There was a problem hiding this comment.
This doesnt feel right. Can we instead catch the error thrown by orb? Also will this ever have floating point errors on their side?
Member
Author
There was a problem hiding this comment.
This is string comparison, for example for credit trial currency is credits not USD so its just comparing currency string not actual credit value. Do you mean anything else here?
Collaborator
There was a problem hiding this comment.
Ah got it. The variable name confused me.
AdityaHegde
approved these changes
May 26, 2026
| return fmt.Errorf("creating credit_balance_dropped alert: %w", err) | ||
| for iter.Next() { | ||
| a := iter.Current() | ||
| if a.Currency == currency { |
Collaborator
There was a problem hiding this comment.
Ah got it. The variable name confused me.
pjain1
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that alert creation is not missed on existing orgs whose trial not started yet but org has already been created.
Checklist: