plugins: Enable message_waiting in ril #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 16, 2014 17:40
Enable the message_waiting atom in the ril plugin. This exposes the MessageWaiting interface which will allow notification when new voicemails arrive.
The return parameter 'active' was being incorrectly set to an int value instead of a boolean value. This caused the message-waiting code to break.
Contributor
|
+1. Tested on mako image 144. Merging. |
alfonsosanchezbeato
added a commit
that referenced
this pull request
Jan 23, 2014
plugins: Enable message_waiting in ril
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the message_waiting atom in the ril plugin.
This exposes the MessageWaiting interface which will
allow notification when new voicemails arrive.
Note -- actual notification of messages received has not yet been tested as it may require changes to SIM IO. That said, as this interface exposes the VoiceMailboxNumber, which then can be used by the Dialer app to access Voicemail, I've submitted this now.
This has been tested using image r162 on both mako and maguro. Sanity checks were run to ensure that this has no adverse affects on start-up for both unlocked and PIN-locked phones, and basic voice call tests were performed.