Allow style can be set on TouchableOpacity elements inside SegmentedItem #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem elements. This will solve the issue that bigger size Badges may be covered by adjacent SegmentedItem. Set zIndex to Badge element won’t help — it seems zIndex on children elements of a TouchableOpacity will be ignored (tested on iOS 10.3 on a iPhone 6 emulator). Setting zIndex to TouchableOpacity directly will work, however.
Owner
|
It is not the best solution, I have modified the code to solve this bug: cd66c88 |
Author
|
Many thanks. Your solution works better. Closed the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow style can be set on TouchableOpacity elements inside SegmentedItem elements.
This will solve the issue that bigger size Badges may be covered by the content of adjacent SegmentedItem.
Set zIndex to Badge element won’t help — it seems zIndex on children elements of a TouchableOpacity will be ignored (tested on iOS 10.3 on a iPhone 6 emulator).
Setting zIndex to TouchableOpacity directly will work, however.
If you have better solution, please ignore this pull request and let me know.