ci: add build verification for Android and iOS (#123)#135
Merged
Conversation
Adds .github/workflows/ci.yml with three jobs: - JS bundle verification (TypeScript check + expo export for both platforms) running on ubuntu-latest - Android native build: prebuilds the Expo project and assembles a debug APK via Gradle on ubuntu-latest - iOS native build: prebuilds the Expo project, installs CocoaPods, and compiles for iOS Simulator via xcodebuild on macos-latest (CODE_SIGNING_ALLOWED=NO, no credentials required) Close rinafcode#123
|
@Itodo-S Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlwith three jobs that together satisfy the build verification requirements from issue No Build Verification in CI #123ubuntu-latest: type-checks withtsc --noEmit, then exports the Android and iOS JavaScript bundles viaexpo export. Catches broken imports, missing modules, and type errors without requiring native toolchains.ubuntu-latest: usesexpo prebuildto generate the native Android project, then assembles a debug APK via Gradle to confirm the Android native build is not broken.macos-latestwhere Xcode is available: usesexpo prebuildto generate the native iOS project, installs CocoaPods, then compiles for the iOS Simulator withxcodebuild(no code signing required).Test plan
CIworkflow appears under the Actions tab after mergeBuild Verificationjob passes on a PR againstmainAndroid Buildjob produces a debug APK without errorsiOS Buildjob compiles successfully on themacos-latestrunnerexpo exportstepClose #123