feat: implement contextual skeleton loading states for perceived performance (#403)#418
Open
shoaib050326 wants to merge 1 commit into
Open
Conversation
…ormance (rinafcode#403) Replace generic ActivityIndicator spinners with content-aware skeleton screens that match each screen's final UI layout: - CourseViewerSkeleton, QuizSkeleton, SettingsSkeleton, SubscriptionSkeleton, DataGridSkeleton - Updated Suspense fallbacks and component-level loaders in course-viewer, quiz, settings, profile, MobileCourseViewer, SubscriptionManager, AdvancedDataGrid - Fixed duplicate MobileQuizManager declaration bug in app/quiz.tsx - Cleaned up unused imports and orphaned styles - Added 8 new tests in SkeletonScreens.test.tsx Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
|
@shoaib050326 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces generic
ActivityIndicatorspinners with content-aware skeleton screens that match each screen's final UI layout, improving perceived performance per issue #403.Changes
CourseViewerSkeleton,QuizSkeleton,SettingsSkeleton,SubscriptionSkeleton,DataGridSkeleton— each mirrors its screen's structural layout using the sharedSkeletonprimitivecourse-viewer,quiz,settings— now render shapely skeletons instead of spinning circlesnullsinceMobileProfileself-handles loading via itsisLoadingprop + built-in skeletonMobileCourseViewer,SubscriptionManager,AdvancedDataGridnow use skeletons instead ofActivityIndicator+textapp/quiz.tsxhad a duplicateMobileQuizManagerdeclaration and an unimportedlazyScreen()call — cleaned upActivityIndicatorimports and orphanedcenterContent/loadingText/loadingContainerstylesCourseCardSkeleton(was used in screens but not exported) tosrc/components/mobile/index.tsTesting
tests/components/SkeletonScreens.test.tsxvalidating all screen skeletons renderAdvancedDataGrid.test.tsxloading assertion fromActivityIndicator→Animated.ViewRisk / Rollback
Low risk — purely UI loading states. Rollback: revert to
main, theActivityIndicatorpaths still exist structurally inLazyScreen.tsx(untouched utility).Closes #403