Fix/form standardization#158
Merged
RUKAYAT-CODER merged 7 commits intoApr 25, 2026
Merged
Conversation
…ble FormInput component
|
@Agbasimere Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
KINDLY RESOLVE CONFLICT AND FIX CI |
Contributor
|
Kindly resolve conflict and fix CI |
…ation # Conflicts: # package.json # scripts/validate-ui.cjs # src/app/hooks/useSearchFilters.ts # src/components/errors/ErrorBoundarySystem.tsx # src/components/instructor/CourseCreationWizard.tsx # src/form-management/validation/validation-system-example.ts # src/hooks/useSearchFilters.tsx # src/utils/web3/envValidation.ts
Contributor
|
Resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #120
Overview
This PR standardizes the form validation approach across the application by moving away from custom state-based validation to a unified
react-hook-formandZodimplementation. It also introduces a reusableFormInputcomponent to ensure visual and functional consistency.Changes
src/components/forms/FormInput.tsxwhich integrates withreact-hook-formand provides consistent styling, icons, and error messaging for inputs, textareas, and selects.ProfileEditForm.tsxto use the newFormInputcomponent, simplifying the markup and standardizing error handling.courseSchemausing Zod for step-by-step validation.react-hook-forminto the multi-step wizard.FormInputcomponent.Impacted Files
src/components/forms/FormInput.tsx(New)src/components/profile/ProfileEditForm.tsxsrc/components/instructor/CourseCreationWizard.tsxAcceptance Criteria
react-hook-formandZod.FormInputcomponent implemented and used.