Feat/272 search filter persistence#284
Merged
RUKAYAT-CODER merged 3 commits intoApr 28, 2026
Merged
Conversation
|
@JohnOluB Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #272
Search filters, sort order, and query text reset on navigation because
AdvancedSearchInterfaceheld all state in memory viauseAdvancedSearch.This PR adds URL-based persistence so users never lose their search state.
Changes
src/hooks/useSearchState.ts(new)A thin composition hook that wraps
useAdvancedSearchand adds:params and auto-runs the search if any active state is present.
router.replace({ scroll: false }), keeping the address bar in syncwithout polluting the browser history stack.
internal state from the updated
searchParams, guarded by a ref toprevent update loops.
getShareableUrl/copyShareableUrl— returns or copies thecurrent canonical URL for sharing filtered views.
URL param mapping:
qsorttypestopicsdifficultypriceMin/priceMaxratingpageDefault values are omitted from the URL to keep links clean.
src/components/search/AdvancedSearchInterface.tsx(updated)useAdvancedSearch→useSearchState(one-line change).hasSearchednow initialises from the URL so a page reload after asearch correctly restores the results view.
Share2) that appears when resultsare active and copies the shareable URL with a
✓ COPIED!confirmation.Acceptance criteria
Share2,Check)