Security image upload video optimization#557
Open
dot-enny wants to merge 2 commits into
Open
Conversation
|
@dot-enny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict and fix workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of changes
Prevented Denial of Service (DoS): Upgraded ImageUploader.tsx (the core avatar upload component) to use memory-efficient URL.createObjectURL bindings instead of aggressively allocating FileReader.readAsDataURL base64 strings that can easily crash browser memory on large files.
Video Frame Extraction: The component now officially accepts video/* inputs. If a user uploads a video file (e.g. an MP4), the frontend mounts an invisible HTML5 video tag, automatically seeks to the middle or 1st second, extracts a high-quality frame to a , and converts it completely on the client side into an 85% optimized static JPEG File.
Security & Speed: This ensures that regardless of the initial video size, the backend API is only ever hit with a lightweight optimized image!
Test Suite Added: Since it lacked coverage, I created a robust unit testing suite at src/components/shared/tests/ImageUploader.test.tsx utilizing heavy DOM mocking for HTML5 videos and canvas elements.
Related Issue
Closes #516
Type of Change
Checklist