fix: contextualize email redaction in audit logs and error reports#862
Merged
RUKAYAT-CODER merged 1 commit intoJun 29, 2026
Merged
Conversation
|
@AbuJulaybeeb Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Removed email from the global SENSITIVE_KEYS list and Pino logger redact paths in src/lib/logging/index.ts.
Implemented targeted email redaction inside the src/app/api/errors/report/route.ts handler to protect deeply nested PII.
Applied contextual email redaction logic to ensure form data handlers can safely filter email addresses before persisting error state.
Updated the assertions in src/lib/logging/logger.test.ts to confirm that valid audit emails are now retained without compromising credential redaction behaviors.
Why it was done To resolve an over-redaction bug where audit logs were stripping the actor's email (a critical identifier for security investigations), while still maintaining strict PII redaction for user-submitted form state and error payloads.
How it was verified Manually analyzed form payloads and executed npx vitest run src/lib/logging/logger.test.ts which verified that standard credential strings and objects are appropriately masked, while basic logging contexts (like actor emails) pass unredacted.
✅ Required line:
Closes #781