Add support for Authorization request header#11
Add support for Authorization request header#11weavejester merged 1 commit intoring-clojure:masterfrom
Conversation
weavejester
left a comment
There was a problem hiding this comment.
Thank you very much for the PR. I've reviewed the code, and it looks good overall, but I have some suggestions/alterations (mostly to do with the coding style guidelines Ring uses).
weavejester
left a comment
There was a problem hiding this comment.
Thanks very much for the updates. I have a few smaller changes/suggestions, but the only major thing left is to make the tests a little more robust.
weavejester
left a comment
There was a problem hiding this comment.
Thanks for all your work! This all looks good aside from a couple of very minor formatting comments. Can you squash down your commits and give the result an appropriate commit message? Then I'll merge it in and cut a release.
9d036be to
fb74d88
Compare
You are welcome! Thanks for taking the time to review this!
Does fb74d88 work? |
|
Almost! Git commit messages are typically wrapped at 72 characters, and at least in this repository they're plaintext rather than markdown, so backticks are unnecessary. I also thought the first paragraph was a little hard to understand, so I rewrote it: I also don't think we need to go into too much detail about why we're updating the Ring dependency. Updating dependencies is a natural part of updating a library. |
Add the wrap-authorization middleware for parsing the Authorization header on the request map. This is not a complete authentication system; it only parses the auth token and parameters. See RFC 7235 and RFC 9110: * https://datatracker.ietf.org/doc/html/rfc7235 * https://datatracker.ietf.org/doc/html/rfc9110#section-11 This change raises the dependency on ring-core to 1.8.1, and drops support for Clojure 1.5 and 1.6.
fb74d88 to
41af011
Compare
|
I changed the commit message in 41af011. |
No complete authentication scheme, but the "Access Authentication Framework"
defined by RFC 7235, providing the building blocks to implement auth schemes.
Raises dependency on ring-core to 1.8.1.
ring.util.parsing/re-valuewasadded in 1.3, but until 1.8.1 it did not capture the content of quoted values
without the quotes. This drops support for Clojure 1.5 and 1.6, since 1.8.1
requires Clojure 1.7.