test tweak: allow resource-response to return InputStream or File#548
test tweak: allow resource-response to return InputStream or File#548The-Alchemist wants to merge 1 commit intoring-clojure:masterfrom
Conversation
|
The test you've modified is explicitly checking resources from a jar file are returned as an InputStream, so changing it to check for a File as well defeats the point of the test. What circumstances are you running the tests under that the |
|
Indeed, great point. This is an quite unique oddball case, as I'm working another Clojure fork like Babashka called Cloffle https://github.com/The-Alchemist/cloffle-clojure), so the files are exploded. I'm using Maybe there's a better way to achieve this goal? |
|
The test needs a jar file on the classpath. As I'm unfamiliar with your setup, I'm unsure how best to go about solving this. Are all dependencies exploded, or just Clojure core? Could we just use a different resource? |
This way, we do not have to assume that Clojure sources are present in a JAR on the classpath. Signed-off-by: The-Alchemist <karl@digital-alchemy.io>
Just Clojure code is exploded. So we can just check any resource on the classpath. I force-pushed a new change that checks the file |
If the tests are run from a JAR, the response will be an
InputStream. In exploded sources, the response can be aFile.Tests now check for either