Skip to content

Conversation

@ele828
Copy link
Contributor

@ele828 ele828 commented Feb 13, 2018

No description provided.

@ele828 ele828 requested a review from embbnux February 13, 2018 07:52
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep showFeedback

sophiewu2333 and others added 8 commits February 13, 2018 21:28
* add fetch-mock to widget

* add mock data to widget integration test

* add new line for json file

* fix test

* update sms response data template

* update mock response json

* reduce timeout time

* reduce timeout time for mock response
…sue (ringcentral#784)

* navigates user to Google Forms in Feedback

* remove unread count on recent activity card

* fix presence subscription issue

* enhance presence permissions check

* hide composeText tab

* replace contact icon & adjust tab navigation styles

* replace contact icon
* feat: new user tutorial

* add propTypes check for UserGuide component

* update user guide

* remove useless stylesheets

* add webphone ready checks

* add unit test for UserGuide && some updates

* remove opacity effect on carousel contol pane

* reserve app header when on user guide

* make user guide label on setting page configurable

* make user guide images stretching from top

* upload temporary posters for test

* make sure UserGuide.guides will always be an Array even if there is no values in localStorage

* import user guide images

* remove useless params for UserGuide

* update guides images

* move button down a bit on intro page to fit mock up

* remove userguide in widgets

* remove legacy pushHeader state

* remove legacy pushHeader state - cont

* remove UserGuide dependency from AdapterModuleCore

* remove pushHeaderState function invoke to fix transport issue

* remove webphone deps from user guide life cycle

* add ringSession check to avoid auto-dismiss issue
* change presence permissions to depend on call permissions

* add UserGuide to widget dev-server
subrepo:
  subdir:   "packages/ringcentral-widgets"
  merged:   "679889b2d"
upstream:
  origin:   "https://github.com/ringcentral/ringcentral-js-widgets.git"
  branch:   "master"
  commit:   "1669673c8"
git-subrepo:
  version:  "0.3.1"
  origin:   "???"
  commit:   "???"
@ele828 ele828 reopened this Feb 13, 2018
@ele828 ele828 merged commit 3793e82 into ringcentral:master Feb 13, 2018
@RingCentralIntegrationDev

Build successful! You can check your changes here: https://ec2-52-17-190-173.eu-west-1.compute.amazonaws.com/job/widget-docker/10/

embbnux pushed a commit to embbnux/ringcentral-js-widget that referenced this pull request Apr 25, 2018
* add mock data to widget integration test (ringcentral#791)

* add fetch-mock to widget

* add mock data to widget integration test

* add new line for json file

* fix test

* update sms response data template

* update mock response json

* reduce timeout time

* reduce timeout time for mock response

* fix bug that dial_in number is undefined in conferencepanel in localization (ringcentral#775)

* update feedback & hide composeText tab & fix presence subscription issue (ringcentral#784)

* navigates user to Google Forms in Feedback

* remove unread count on recent activity card

* fix presence subscription issue

* enhance presence permissions check

* hide composeText tab

* replace contact icon & adjust tab navigation styles

* replace contact icon

* feat: new user tutorial (ringcentral#779)

* feat: new user tutorial

* add propTypes check for UserGuide component

* update user guide

* remove useless stylesheets

* add webphone ready checks

* add unit test for UserGuide && some updates

* remove opacity effect on carousel contol pane

* reserve app header when on user guide

* make user guide label on setting page configurable

* make user guide images stretching from top

* upload temporary posters for test

* make sure UserGuide.guides will always be an Array even if there is no values in localStorage

* import user guide images

* remove useless params for UserGuide

* update guides images

* move button down a bit on intro page to fit mock up

* remove userguide in widgets

* remove legacy pushHeader state

* remove legacy pushHeader state - cont

* remove UserGuide dependency from AdapterModuleCore

* remove pushHeaderState function invoke to fix transport issue

* remove webphone deps from user guide life cycle

* add ringSession check to avoid auto-dismiss issue

* fix contact icon & update icon styles (ringcentral#794)

* fix ui bug in call item page (ringcentral#796)

* Update presence permissions check (ringcentral#805)

* change presence permissions to depend on call permissions

* add UserGuide to widget dev-server

* git subrepo commit packages/ringcentral-widgets

subrepo:
  subdir:   "packages/ringcentral-widgets"
  merged:   "679889b2d"
upstream:
  origin:   "https://github.com/ringcentral/ringcentral-js-widgets.git"
  branch:   "master"
  commit:   "1669673c8"
git-subrepo:
  version:  "0.3.1"
  origin:   "???"
  commit:   "???"

* upgrade commons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants