extract isSaving property in callsMapping from localStorage to memory #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unadlib
approved these changes
May 31, 2018
sophiewu2333
approved these changes
May 31, 2018
u9520107
pushed a commit
to u9520107/ringcentral-js-widgets
that referenced
this pull request
Jun 4, 2018
* add mock data to widget integration test (ringcentral#791) * add fetch-mock to widget * add mock data to widget integration test * add new line for json file * fix test * update sms response data template * update mock response json * reduce timeout time * reduce timeout time for mock response * fix bug that dial_in number is undefined in conferencepanel in localization (ringcentral#775) * update feedback & hide composeText tab & fix presence subscription issue (ringcentral#784) * navigates user to Google Forms in Feedback * remove unread count on recent activity card * fix presence subscription issue * enhance presence permissions check * hide composeText tab * replace contact icon & adjust tab navigation styles * replace contact icon * feat: new user tutorial (ringcentral#779) * feat: new user tutorial * add propTypes check for UserGuide component * update user guide * remove useless stylesheets * add webphone ready checks * add unit test for UserGuide && some updates * remove opacity effect on carousel contol pane * reserve app header when on user guide * make user guide label on setting page configurable * make user guide images stretching from top * upload temporary posters for test * make sure UserGuide.guides will always be an Array even if there is no values in localStorage * import user guide images * remove useless params for UserGuide * update guides images * move button down a bit on intro page to fit mock up * remove userguide in widgets * remove legacy pushHeader state * remove legacy pushHeader state - cont * remove UserGuide dependency from AdapterModuleCore * remove pushHeaderState function invoke to fix transport issue * remove webphone deps from user guide life cycle * add ringSession check to avoid auto-dismiss issue * fix contact icon & update icon styles (ringcentral#794) * fix ui bug in call item page (ringcentral#796) * Update presence permissions check (ringcentral#805) * change presence permissions to depend on call permissions * add UserGuide to widget dev-server * git subrepo commit packages/ringcentral-widgets subrepo: subdir: "packages/ringcentral-widgets" merged: "679889b2d" upstream: origin: "https://github.com/ringcentral/ringcentral-js-widgets.git" branch: "master" commit: "1669673c8" git-subrepo: version: "0.3.1" origin: "???" commit: "???" * upgrade commons
tuluxmu
added a commit
that referenced
this pull request
Jun 6, 2018
* master: set contact search optional in composeText (#814) fix unread message should be highlight (#813) [feature] Apply infinite scrolling list to contacts (#798) update release scripts and add job to release i18n,locale-loader,phone-number (#800) remove uri from cache data (#801) Move ScheduleMeeting test from salesforce to rc-widgets. (#810) fix safari spinner translucence mask (#809) fix test in glip post module (#808) Refresh error (#807) extract isSaving property in callsMapping from localStorage to memory (#805) Refresh error (#806)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve the issue where ticket saving process cannot be proceeded after the saving process is interrupted by accident, e.g. user refresh the page.