Merged
Conversation
Pull Request Test Coverage Report for Build 683
💛 - Coveralls |
Pull Request Test Coverage Report for Build 689
💛 - Coveralls |
flops
requested changes
Oct 17, 2018
| private queueRunning = false; | ||
|
|
||
| constructor(protected transportInstance: ITransport) { | ||
| constructor(protected transportInstance: ITransport, private httpThrottle: number) { |
Collaborator
There was a problem hiding this comment.
Maybe better use options object, with httpThrottle property to solve problem possible additional properties in feature.
| queuedTest.parameters, | ||
| this.config.envParameters | ||
| this.config.envParameters, | ||
| this.config.httpThrottle |
Collaborator
There was a problem hiding this comment.
We have runData property in this.config.parameters. Not sure it's a good idea to make new argument for every config parameter that we will need.
|
|
||
| let isAsync = false; | ||
|
|
||
| this.testAPI.setHttpThrottle(message.httpThrottle); |
Collaborator
There was a problem hiding this comment.
I'd prefer as with execute send this property with test parameters
Contributor
Author
|
@flops Moved httpThrottle to parameters in worker. abstractHttpClient is now using params object. |
flops
approved these changes
Oct 18, 2018
johnthecat
suggested changes
Oct 18, 2018
packages/api/src/test-context.ts
Outdated
| httpThrottle: config.httpThrottle, | ||
| }; | ||
|
|
||
| this.http = new HttpClient(transport, httpClientParams); |
Contributor
There was a problem hiding this comment.
Suggested change
| this.http = new HttpClient(transport, httpClientParams); | |
| this.httpClient = new HttpClient(transport, { | |
| httpThrottle: config.httpThrottle, | |
| }); |
packages/cli/src/commands/record.ts
Outdated
| const httpClientParams = { | ||
| httpThrottle: this.config.httpThrottle, | ||
| }; | ||
| const httpClient = new HttpClientLocal(this.transport, httpClientParams); |
packages/cli/src/commands/run.ts
Outdated
| const httpClientParams = { | ||
| httpThrottle: this.config.httpThrottle, | ||
| }; | ||
| const httpClient = new HttpClientLocal(this.transport, httpClientParams); |
|
|
||
| constructor(protected transportInstance: ITransport) { | ||
| constructor(protected transportInstance: ITransport, private params: HttpClientParams) { | ||
| this.queue = new Queue(); |
Contributor
There was a problem hiding this comment.
Don't use common words for naming
Suggested change
| this.queue = new Queue(); | |
| this.requestQueue = new Queue(); |
| this.queueRunning = false; | ||
| } | ||
|
|
||
| private pushQueue(requestParameters: IHttpRequest, cookieJar?: IHttpCookieJar): Promise<any> { |
Contributor
There was a problem hiding this comment.
Suggested change
| private pushQueue(requestParameters: IHttpRequest, cookieJar?: IHttpCookieJar): Promise<any> { | |
| private pushToQueue(requestParameters: IHttpRequest, cookieJar?: IHttpCookieJar): Promise<any> { |
|
|
||
| private pushQueue(requestParameters: IHttpRequest, cookieJar?: IHttpCookieJar): Promise<any> { | ||
| return new Promise(async (resolve, reject) => { | ||
| this.queue.push(() => this.sendRequest(requestParameters, cookieJar).then(resolve, reject)); |
Contributor
There was a problem hiding this comment.
Move function to separated variable
| let screenshotsEnabled = false; | ||
| let isRetryRun = queueItem.retryCount > 0; | ||
| const { | ||
| debug = false, |
Contributor
There was a problem hiding this comment.
don't use default values, they must be already defined in config
johnthecat
approved these changes
Oct 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.