This repository was archived by the owner on Oct 28, 2025. It is now read-only.
more keylet functions #126
Merged
+821
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
reviewed
Aug 7, 2025
projects/decoder_tests/src/lib.rs
Outdated
| let _ = trace_data(" IOU Asset:", &buf[..output_len as usize], DataRepr::AsHex); | ||
| } | ||
|
|
||
| fn test_deposit_preauth() { |
Collaborator
There was a problem hiding this comment.
Can these tests be alphabetized? Easier to see if something is missing that way
mvadari
reviewed
Aug 7, 2025
wasm-host/src/host_functions_wamr.rs
Outdated
|
|
||
| pub fn check_keylet( | ||
| _env: wasm_exec_env_t, | ||
| account_buf_ptr: *mut u8, |
mvadari
reviewed
Aug 7, 2025
wasm-host/src/host_functions_wamr.rs
Outdated
|
|
||
| pub fn delegate_keylet( | ||
| _env: wasm_exec_env_t, | ||
| account_ptr: *mut u8, |
Collaborator
There was a problem hiding this comment.
ditto for all these functions
mvadari
reviewed
Aug 8, 2025
| .register_host_function("float_root", float_root as *mut c_void, "(*~i*~i)i", 100, data_provider.as_ptr()) | ||
| .register_host_function("float_log", float_log as *mut c_void, "(*~*~i)i", 100, data_provider.as_ptr()) | ||
| .register_host_function("trace_opaque_float", trace_opaque_float as *mut c_void, "(*~*~)i", 500, data_provider.as_ptr()) | ||
| .register_host_function("check_keylet", check_keylet as *mut c_void, "(*~i*~)i", 350, data_provider.as_ptr()) |
Collaborator
There was a problem hiding this comment.
What do the *~ mean here? I'm not familiar with this syntax
mvadari
reviewed
Aug 8, 2025
| let data_source = MockData::new(&tx_json, &lo_json, &lh_json, &l_json, &nft_json); | ||
| info!("Executing function: {}", args.function); | ||
| match vm_wamr::run_func(wasm_file, &args.function, Some(100000), data_source) { | ||
| match vm_wamr::run_func(wasm_file, &args.function, Some(1000000), data_source) { |
Collaborator
There was a problem hiding this comment.
Note: this should be lowered before we release to match whatever we have in rippled
Collaborator
Author
There was a problem hiding this comment.
agree. we have an issue created for that
#73
mvadari
approved these changes
Aug 8, 2025
Collaborator
mvadari
left a comment
mvadari
left a comment
There was a problem hiding this comment.
a couple questions but nothing to block merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.