This repository was archived by the owner on Oct 28, 2025. It is now read-only.
set up basic CI #20
Merged
set up basic CI #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR sets up basic CI and refactors several code modules for improved formatting and maintainability while adding additional CI workflow steps. Key changes include reordering and formatting improvements in the VM and CLI modules, updates to logging and error messages, and the addition of a GitHub Actions workflow for linting, formatting, and testing.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wasm-host/src/vm.rs | Reordered imports and improved formatting in run_func; duplicated memory allocation logic noted. |
| wasm-host/src/main.rs | Reformatted import order and conditional blocks for better readability. |
| src/utils/wasm_fingerprint.rs | Adjusted import order and digest call style without functional changes. |
| src/utils/mod.rs | Reorganized imports and enhanced multi-line formatting for clarity. |
| src/main.rs | Improved formatting and consistency in user prompts and CLI interaction. |
| .github/workflows/test.yml | Added CI workflow for linting, formatting, and build/test processes. |
| /// The function expects the WASM module to expose an "allocate" function that allocates memory | ||
| /// for the host to write data into. | ||
| pub fn run_func<T: SyncInst>(vm: &mut Vm<T>, func_name: &str, tx_data: Vec<u8>, lo_data: Vec<u8>) -> Result<bool, Box<dyn std::error::Error>> { | ||
| pub fn run_func<T: SyncInst>( |
There was a problem hiding this comment.
[nitpick] The memory allocation logic for both transaction and ledger object data is duplicated. Consider abstracting this repeated logic into a helper function to improve maintainability.
sappenin
reviewed
May 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.