Amm rankings explorer page by cybele-ripple · Pull Request #1295 · ripple/explorer

cybele-ripple · 2026-03-16T19:13:46Z

High Level Overview of Change

These changes add an AMM page to the explorer.

Context of Change

The new AMMs page includes:

a graph for TVL and volume
- toggle for USD and XRP
- selectable timeframe (1D, 1M, 6M, 1Y, 5Y)
- color coded superimposed graphs
top 1000 AMMs
- entry includes: pair, clickable AMM account ids, TVL, number of LPs, volume in past 24 hours, feed in past 24 hours, and APR in past 24 hours
- toggle switch from USD and WRP
- filters for AMMs (RWA, Stablecoins, Memes, DeFi)
- search box for specific AMM
general info section to show current TVL, total number of AMMs, total number of LPs and the current 24 hour volume

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Tests (You added tests for code that already exists, or your new feature included in this PR)
Documentation Updates
Translation Updates
Release

semgrep-code-ripple-github-org · 2026-03-16T19:20:17Z

Semgrep found 10 ssc-7ae6e5c3-b6de-4d40-8faa-c9762551977a findings:

src/containers/AMMRankings/api.ts
- L63 - Triage
- L121-127 - Triage
- L163 - Triage
- L173-178 - Triage
- L189-194 - Triage
server/routes/v1/tokens.js
- L220 - Triage
- L245 - Triage
server/routes/v1/amms.js
- L17-23 - Triage
- L48 - Triage
- L74-79 - Triage

Risk: Affected versions of axios are vulnerable to Improper Check for Unusual or Exceptional Conditions. It fails to correctly validate configuration keys during merging. This allows a crafted proto property to trigger an internal TypeError, causing the application to crash.

Fix: Upgrade this library to at least version 1.13.5 at explorer/package-lock.json:27214.

Reference(s): GHSA-43fc-jf86-j433, CVE-2026-25639

pdp2121 · 2026-03-26T16:33:04Z

+ * GET /api/v1/amms
+ * Fetch top AMMs with sorting
+ */
+const getAMMs = async (req, res) => {


You should cache these results so that Explorer server will not make a call to LOS on every page load (rate limiting)
See this example: https://github.com/ripple/explorer/blob/main/server/routes/v1/tokens.js#L85-L119

Added to the top of this file https://github.com/ripple/explorer/pull/1295/changes#diff-3d739c4ee7d382a3089fc92fe71742ee94b21e2d701aa157f072f31446d89fd7R5-R11

pdp2121 · 2026-03-26T16:33:53Z

+    log.info(`Fetched ${response.data.results?.length || 0} AMMs`)
+
+    return res.status(200).json(response.data)
+  } catch (error) {


Also with caching if the call failed we can still use stale data

Added to this file here https://github.com/ripple/explorer/pull/1295/changes#diff-3d739c4ee7d382a3089fc92fe71742ee94b21e2d701aa157f072f31446d89fd7R279-R298

pdp2121 · 2026-03-26T16:34:11Z

+ * Fetch aggregated AMM statistics
+ * This fetches the special "aggregated" document from the amms index
+ */
+const getAggregatedStats = async (req, res) => {


Same here, this should be cached

Added https://github.com/ripple/explorer/pull/1295/changes#diff-3d739c4ee7d382a3089fc92fe71742ee94b21e2d701aa157f072f31446d89fd7R279-R298

pdp2121 · 2026-03-26T16:34:22Z

+ * Fetch historical trends for AMM data
+ */
+const getHistoricalTrends = async (req, res) => {
+  try {


Added: https://github.com/ripple/explorer/pull/1295/changes#diff-3d739c4ee7d382a3089fc92fe71742ee94b21e2d701aa157f072f31446d89fd7R11

pdp2121 · 2026-03-26T16:39:45Z

  api.use('/metrics', getCurrentMetrics)
  api.use('/tokens/search/:query', getTokensSearch)
+  api.post('/tokens/batch-get', batchGetTokens)
+  api.use('/tokens/:tokenId', getTokenById)


Is there a reason for this to be done server-side? For single token fetching without the need for caching I would prefer doing it on client-side to avoid rate limiting (IP of user browser vs IP of Explorer server)

Changed to cache the data serverside instead of fetching per request here https://github.com/ripple/explorer/pull/1295/changes#diff-3d739c4ee7d382a3089fc92fe71742ee94b21e2d701aa157f072f31446d89fd7R236-R250

pdp2121 · 2026-04-07T15:24:00Z

+    ['ammRankings', sortField, sortOrder],
+    () => fetchAMMRankings(sortField, sortOrder),
+    {
+      refetchInterval: 60 * 1000,


nit: you can set a common refetch interval variable

kuan121 · 2026-04-08T13:52:24Z

@@ -911,5 +911,15 @@
  "asset_2": "Asset 2",


Once you’ve finalized all the new keys for the AMM Ranking page, please add the same keys to translations.json for the other languages and set their values to null (you can refer to the AMM Object PR for examples).

Added changes from this translations.json to the following:
ca-CA
es-ES
fr-FR
ja-JP
ko-KR
my-MM

kuan121 · 2026-04-09T01:48:43Z

+              <span>{CATEGORY_LABELS[cat]}</span>
+            </button>
+          ))}
+          <div className="search-wrapper">


Sorry, I meant the search box "Search AMMs" in the Top 1,000 AMMs section. I don't see it in the screenshot.

kuan121 · 2026-04-10T18:27:13Z

@@ -2,6 +2,7 @@
  "action": "acció",


This comment applies to all the non en-US translation.json files. We introduce the following 11 new translation keys in the en-US/translation.json file:

"asset_pair" "amms" "top_1000_amms" "general_info" "number_of_amms" "number_of_lps" "number_of_amms_tooltip" "number_of_lps_tooltip" "search_amms" "tvl_tooltip" "volume_24h_all_tooltip"

What I expect are

They will show up in other non en-US files

No other changes are needed, but I'm seeing lots of other key addition/removals as well. Is it a result of running some sort of formatter? If that's the case, just make sure we don't accidentally delete/add any used/unused keys, then we are good.

It is a formaI did use a formatter. I just confirmed that the changes made in the file are all cosmetic OR part of the list you gave above. Those 11 translation keys are the only additive change between this branch and your branch

kuan121 · 2026-04-10T18:35:02Z

+          ? formatCurrencyAmount(getFees24h(amm))
+          : DEFAULT_EMPTY_VALUE}
+      </td>
+      <td className="apr">


The APR value doesn't need to be bold or semi-bold.

APR is no longer bold

This reverts commit c7df640.

…g, adding to translations.json

…TVLVolumeChart

…, data_available_from_notice

pdp2121 reviewed Mar 26, 2026

View reviewed changes

kuan121 reviewed Apr 1, 2026

View reviewed changes

kuan121 reviewed Apr 2, 2026

View reviewed changes

cybele-ripple force-pushed the amm-rankings-explorer-page branch from f1682aa to ec81759 Compare April 3, 2026 23:04

cybele-ripple changed the base branch from main to amm-object-page April 3, 2026 23:08

cybele-ripple force-pushed the amm-rankings-explorer-page branch from b6341b2 to c030e5b Compare April 6, 2026 21:03

pdp2121 reviewed Apr 7, 2026

View reviewed changes

kuan121 reviewed Apr 8, 2026

View reviewed changes

Comment thread src/containers/AMMRankings/AMMRankingsTable.tsx Outdated

kuan121 reviewed Apr 9, 2026

View reviewed changes

Comment thread src/containers/AMMRankings/index.tsx

cybele-ripple requested review from kuan121 and pdp2121 April 9, 2026 21:25

kuan121 reviewed Apr 10, 2026

View reviewed changes

kuan121 force-pushed the amm-object-page branch 2 times, most recently from e8b65ba to e09b907 Compare April 10, 2026 20:21

kuan121 added 2 commits April 10, 2026 13:49

Initial commit for AMM Pool page

ea48288

Correctly handle fully liquidated AMM pools

992b398

pdp2121 approved these changes Apr 10, 2026

View reviewed changes

kuan121 and others added 6 commits April 10, 2026 14:19

minor refactoring

f15b9a2

remove unused or duplicate keys

8478a74

Revert "Delete old AMM Pool code"

393b28d

This reverts commit c7df640.

initial commit for AMM rankings page

7ca4f3f

make TVL volume chart reusable

9d4bd57

added caching and move from client side to serverside for token fetching

70b0ff8

cybele-ripple added 8 commits April 10, 2026 16:33

addressed PR comments

281c82d

linting fix

65afb94

fix mobile view

9482567

remove bolded

31bcaab

applied changes based on second round of comments including formattin…

c1f5d26

…g, adding to translations.json

revert unrelated code changes

ca02fec

unbold APR and extend amm search bar on main

1b7df8f

adjust width of amm search box

b04fbe0

cybele-ripple force-pushed the amm-rankings-explorer-page branch from 8f44fb4 to b04fbe0 Compare April 10, 2026 23:42

cybele-ripple added 16 commits April 12, 2026 10:54

fix linting

e2e3f5e

fix: resolve test failures after rebase onto amm-object-page

2ee4d68

style: prettier format MarketDataCard

08c21b3

fix: resolve TypeScript build errors in MarketDataCard, TablePicker, …

acbe8f4

…TVLVolumeChart

fix: restore missing translation keys lp_token_balance, token_balance…

95ea134

…, data_available_from_notice

fix: lint errors in TVLVolumeChart

dbf993e

fix: cast FocusEvent to MouseEvent in TVLVolumeChart onFocus handler

8b181a1

remove duplicates

8b16649

Merge branch 'amm-object-page' into amm-rankings-explorer-page

b3f7ae2

resolve linting

98fc58b

remove unchanged files

92b4e30

remove unused files

257f625

revert changes unrelated to AMM rankings

27722ad

remove extra files

2fb45bd

revert extra code

7f8da25

revert unrelated changes

8fa155a

kuan121 reviewed Apr 14, 2026

View reviewed changes

revert changes based on newest PR comments

44a168c

cybele-ripple requested a review from kuan121 April 14, 2026 23:16

revert unrelated changes in translations files

27cfaf1

cybele-ripple merged commit 7eee154 into amm-object-page Apr 15, 2026
5 checks passed

Conversation

cybele-ripple commented Mar 16, 2026

High Level Overview of Change

Context of Change

Type of Change

Uh oh!

semgrep-code-ripple-github-org Bot commented Mar 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cybele-ripple Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cybele-ripple Apr 7, 2026 •

edited

Loading