Skip to content

Conversation

@patrick-rivos
Copy link
Collaborator

In #1264, I changed the name of the generated artifacts in build.yaml, but missed the corresponding name in nightly-release.yaml.
This PR fixes that so the LLVM/GCC generated artifacts don't have a naming clash and overwrite eachother in the release flow.

@TommyMurphyTM1234
Copy link
Collaborator

Apologies if it's a dumb question but is this PR aimed at addressing the issue that currently leaves "nightly" builds with no llvm tools? For example:

@patrick-rivos
Copy link
Collaborator Author

Yep! that's what this PR aims to fix.
FWIW, the riscv32-glibc-ubuntu-20.04-nightly-2023.06.09-nightly.tar.gz and riscv64-glibc-ubuntu-20.04-nightly-2023.06.09-nightly.tar.gz appear to have LLVM tools in them. I would guess that's due to the LLVM builds taking longer than the GCC build+testsuite runtime.

Copy link
Collaborator

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@kito-cheng kito-cheng merged commit 6da3855 into riscv-collab:master Jun 28, 2023
@patrick-rivos patrick-rivos deleted the llvm-release-ci branch September 12, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants