Skip to content

feat: chain upgrade 29#49

Merged
dzung-rise merged 1 commit intomainfrom
chain-upgrade-29-2
Apr 6, 2026
Merged

feat: chain upgrade 29#49
dzung-rise merged 1 commit intomainfrom
chain-upgrade-29-2

Conversation

@dzung-rise
Copy link
Copy Markdown
Contributor

@dzung-rise dzung-rise requested a review from hai-rise as a code owner April 6, 2026 09:08
@dzung-rise dzung-rise merged commit 92d3a56 into main Apr 6, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the image tags for the rise-exec and rise-node services in the docker-compose.yml file. Feedback indicates that the hardcoded --identity flag for the rise-exec service may now be outdated and should be updated or removed to ensure consistency with the new image version.

Comment thread docker-compose.yml
services:
rise-exec:
image: public.ecr.aws/risechain/risechain-public/rise-exec/node:sha-624a411
image: public.ecr.aws/risechain/risechain-public/rise-exec/node:sha-f97ed60
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The update of the rise-exec image to sha-f97ed60 makes the hardcoded --identity flag in the service command (line 30) outdated. The current identity string rise-4f9b653/reth-main-8367ba4/linux-aarch64 references an older commit hash (4f9b653). Consider updating this flag to reflect the new version or removing it entirely to allow the node to use its default identity, which typically includes the correct version and architecture information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant