Skip to content

feat(array,types): support vector type#866

Merged
wangrunji0408 merged 2 commits intomainfrom
skyzh/vector
Jan 16, 2025
Merged

feat(array,types): support vector type#866
wangrunji0408 merged 2 commits intomainfrom
skyzh/vector

Conversation

@skyzh
Copy link
Member

@skyzh skyzh commented Jan 8, 2025

@skyzh skyzh requested a review from xxchan January 8, 2025 04:16
skyzh and others added 2 commits January 11, 2025 15:33
Signed-off-by: Alex Chi Z <iskyzh@gmail.com>

fix clippy + rename

Signed-off-by: Alex Chi Z <iskyzh@gmail.com>

new_in_memory

Signed-off-by: Alex Chi Z <iskyzh@gmail.com>

fix tests

Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh
Copy link
Member Author

skyzh commented Jan 16, 2025

(ping for reviews, thanks)

Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit 4144c89 Jan 16, 2025
@wangrunji0408 wangrunji0408 deleted the skyzh/vector branch January 16, 2025 09:49
github-merge-queue bot pushed a commit that referenced this pull request Jan 26, 2025
requires: #866

This patch adds a new array type for vector arrays.

The array stores primitive type chunks of the same length. Trying to
inserting chunks of different sizes will panic.

#864

---------

Signed-off-by: Alex Chi Z <iskyzh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants