Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
============================================
- Coverage 69.93% 69.92% -0.02%
Complexity 2766 2766
============================================
Files 1052 1052
Lines 92427 92464 +37
Branches 1790 1790
============================================
+ Hits 64638 64652 +14
- Misses 26898 26921 +23
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: TennyZhuang <zty0826@gmail.com>
| build_binary_funcs( | ||
| &mut map, | ||
| &[E::Multiply], | ||
| &[T::Interval], | ||
| &[T::Int16, T::Int32, T::Int64], | ||
| T::Interval, | ||
| ); | ||
| build_binary_funcs( | ||
| &mut map, | ||
| &[E::Multiply], | ||
| &[T::Int16, T::Int32, T::Int64], | ||
| &[T::Interval], | ||
| T::Interval, | ||
| ); |
There was a problem hiding this comment.
I'd prefer to add build_cummulative_binary_ops to combine the two definitions.
There was a problem hiding this comment.
Agree! I can do it in next PR, there are many other types can use this.
There was a problem hiding this comment.
xiangjinwu
left a comment
There was a problem hiding this comment.
lgtm. As mentioned in #1666, pg actually support int2/int4/int8/numeric/float4/float8. It can be supported either with generics or implicit cast. For now we can keep this implementation.
Signed-off-by: TennyZhuang zty0826@gmail.com
What's changed and what's your intention?
As title
Checklist
Refer to a related PR or issue link (optional)
#112