finished testing exercises in testing.js and testingSpec.js #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt could be done better.
tigarcia
reviewed
Aug 7, 2017
|
|
||
| document.addEventListener("keyup", function(e) { | ||
| //I feel like this nested if statements can be condensed. | ||
| if (timerSpan.innerHTML > 29) { |
There was a problem hiding this comment.
This should be a better way of tracking this. If I hit the space bar mutliple times before the time changes to 29, weird things might start happening. I would just keep a variable to tell if the game has started or not. I think I called it gameOn in my solution.
tigarcia
reviewed
Aug 14, 2017
| } | ||
| } | ||
| } | ||
| obj.person.sayHi.call(obj) |
There was a problem hiding this comment.
You can also do:
obj.person.sayHi = obj.person.sayHi.bind(obj);
| var evens = [] | ||
| arr.forEach(function(element) { | ||
| if (element % 2===0) { | ||
| evens.push(element) |
There was a problem hiding this comment.
instead of pushing all of the evens into a new array, you could just do the sum here.
|
|
||
| //Implement your own version of Function.prototype.bind | ||
|
|
||
| Function.prototype.bind = function(thisArg, ...outerArgs) { |
tigarcia
reviewed
Aug 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.