finished tests; working on implementing functions #39

MiHHuynh · 2017-08-01T04:22:49Z

Wrote tests
Working on implementing functions, not sure if I'll be able to finish tonight, but will try my best...

MiHHuynh · 2017-08-02T03:20:20Z

Recursion exercises: productOfArray, collectStrings, contains

mmmaaatttttt

couple of small comments on the testing exercises, but nice job!

mmmaaatttttt · 2017-08-03T01:01:14Z

testing_exercise/testing.js

@@ -1,0 +1,47 @@
+function replaceWith(str, replaceThisChar, replacementChar) {
+	var arrayOfChars = str.split("");
+	arrayOfChars.forEach(function(val, index){


nice work. can you think of a way to refactor this using a map?

Just refactored it with a map. I think it looks cleaner now. :)

function replaceWith(str, replaceThisChar, replacementChar) { return str.split("").map(function(val, index, array){ if (val === replaceThisChar) return replacementChar; return val; }).join(""); }

mmmaaatttttt · 2017-08-03T01:01:35Z

testing_exercise/testing.js

+}
+
+function expand(arr, num) {
+	if (num === 1) {


do you need this if statement?

I was thinking that in the case of num === 1, or with no repeats, I would just return to save the work of going into the for loop, but I can see that it's just unnecessary code. I'll remove it.

elie

Good job! Set your indentation to 2 spaces in your editor, keep it up!

elie · 2017-08-03T16:21:09Z

lodash_exercise/lodash.js

+function drop(arr, num=1){
+	if (num === 1) {
+		return arr.slice(1);
+	} else {


Don't need the else here since you're returning in both cases.

elie · 2017-08-03T16:21:29Z

lodash_exercise/lodash.js

+function head(arr){
+	if (arr.length === 0) {
+		return undefined;
+	} else {


same comment as above, don't need the else here.

elie · 2017-08-03T16:21:47Z

lodash_exercise/lodash.js

+function takeRight(arr, num=1){
+	if (num === 0) {
+		return []
+	} else {


You guessed it! Don't need the else here as well.

elie · 2017-08-03T16:22:17Z

lodash_exercise/lodash.js

+		}
+		return false;
+	}
+	return (collection.slice(fromIndex).indexOf(val) !== -1) ? true : false;


Nice! You don't need () around the expression here

elie · 2017-08-03T16:22:54Z

lodash_exercise/lodash.js

-function flatten(){
-
+function flatten(arr){
+	//NOT WORKING


Try to use helper method recursion to solve this

elie · 2017-08-03T16:23:22Z

lodash_exercise/lodash.js

+	var result = [];
+	for (var i = 0; i < arr.length; i++) {
+		if (Array.isArray(arr[i])) {
+			flatten(arr[i]);


If you wanted to use pure recursion you would have to reassign result with an expression like result = result.concat(flatten(arr[i]))

elie · 2017-08-03T16:23:52Z

recursion_exercise/recursion.js

+}
+
+function binarySearch(arr, val) {
+	// sort the array


Try this one when you have some time - you're getting the hang of recursion!

elie · 2017-08-03T16:24:29Z

testing_exercise/testing.js

+
+function acceptNumbersOnly() {
+	for (var i = 0; i < arguments.length; i++) {
+		if (typeof(arguments[i]) !== "number" || isNaN(arguments[i])) {


check out the method Number.isFinite - it's a useful way to avoid the logic here

MiHHuynh · 2017-08-08T22:51:31Z

Hi--everything I pushed in the past few days are ready for review. Thanks!

tigarcia

Good job! Let me know if I missed anything

tigarcia · 2017-08-11T17:01:37Z

call_apply_bind_exercise/callApplyBind.js

@@ -1,0 +1,55 @@
+function sumEvenArguments() {
+  var arr = [].slice.call(arguments);


I'm not sure if you had learned spread yet, but you can do

function sumEvenArguments(...arr) {

tigarcia · 2017-08-11T17:03:47Z

call_apply_bind_exercise/callApplyBind.js

+  }
+}
+
+function guessingGame(num) {


Good job here.

tigarcia · 2017-08-11T17:06:23Z

call_apply_bind_exercise/readme.md

        sayHi: function(){
            return "This person's name is " + this.fullName
-        }
+        }.apply(obj)


I think you want to use bind here:

var obj = { fullName: "Harry Potter", person: { sayHi: function() { return "This person's name is " + this.fullName; } } } obj.person.sayHi = obj.person.sayHi.bind(obj);

tigarcia · 2017-08-11T17:11:53Z

canvas_exercise/shapes_game/index.js

+    if (randomShapeNumber === 1) {
+      expectedKey = "white0";
+      ctx.fillStyle = "white";
+      ctx.beginPath();


Lots of duplicate code between these two if statements. I'd try to consolidate it and only change the color based on red or white triangle

tigarcia · 2017-08-11T17:12:55Z

canvas_exercise/shapes_game/index.js

      scoreSpan = document.getElementById("score-val"),
-      seconds = 3,
+      score = 0,
+      seconds = 30, // added a 0 to make it 30?


yep, I think I had it at 3 seconds when I was testing

tigarcia · 2017-08-11T17:17:21Z

es2015_exercise/readme.md

+    sayHi(){
+        setTimeout(() => {
            console.log("Your name is " + this.fullName)
        }.bind(this),1000)


bind isn't needed because the arrow functions use the this from the surrounding area. Also, the curly braces aren't needed for a 1 line arrow function. So you can simplify to:

var person = { fullName: "Harry Potter", sayHi(){ setTimeout(() => console.log("Your name is " + this.fullName),1000) } }

tigarcia · 2017-08-11T17:22:42Z

es2015_exercise/readme.md

-var temp = arr[0]
+let temp = arr[0]
 arr[0] = arr[1]
 arr[1] = temp


this can be simplified to:

let arr = [1,2]; arr = [arr[1], arr[0]]

tigarcia · 2017-08-11T17:25:09Z

es2015_exercise/readme.md

+//    });
+// }
+
 function double(arr){


const double = arr => arr.map(v => v * 2);

tigarcia · 2017-08-11T17:28:30Z

prototypes_exercise/prototypes.js

+  return result.join("");
+}
+
+Function.prototype.bind = function(thisArg, ...outerArgs) { // anon func takes thisArg to reset the this, and other arguments if needed


tigarcia · 2017-08-11T17:29:56Z

prototypes_exercise/prototypes.js

+String.prototype.reverse = function() {
+  var result = [];
+  let temp = this.split("");
+  for (let i = temp.length-1; i >= 0; i--) {


Nice use of an array. You could probably just do this as well:

String.prototype.reverse = function() { return this.split("").reverse().join(""); }

tigarcia

I didn't see your hacker snooze ajax solution. Did you forget to submit it?

…and favorites

MiHHuynh · 2017-08-14T23:59:40Z

Hi Tim. My hack or snooze app is pretty bare bones at the moment. I pushed what I currently have, but I'm still working on it. Also I haven't started Tic Tac Toe, so no commits related to that for now.

MiHHuynh added 5 commits July 31, 2017 21:21

finished tests; working on implementing functions

a7a05c8

finished cceptNumbersOnly function

f461d1a

finished mergeArrays function

2068677

finished mergeObjects function. all tests passed

1828583

finished productofarray, collectstrings, contains

a458e2d

MiHHuynh added 7 commits August 2, 2017 11:07

finished search in recursion exercises

39ef109

fixed typo in recursion tests

24b3ca6

edited sort function to compare numbers properly

f621f0a

working on binary search

f42f98e

lodash exercises: drop, fromPairs

a772b65

head, take, takeRight, union, zipObject

ca2195c

includes, sample, cloneDeep

0d0e826

mmmaaatttttt reviewed Aug 3, 2017

View reviewed changes

MiHHuynh added 2 commits August 3, 2017 08:56

some more functions for lodash exercise

ef62251

added pickBy, omitBy

2beb2c8

elie requested changes Aug 3, 2017

View reviewed changes

MiHHuynh added 13 commits August 3, 2017 12:00

lodash functions, working on flatten

fc8cca5

initial commit for new pull request

e8ea7cd

finished canvas shapes game

f986863

removed repeated code

608e512

removed some unnecessary elses

1c272a4

removed if statement in expand

8198184

implemented replaceWith using a map instead of forEach

d0f6d3e

reindented everything with spaces instead of tabs

203b72d

finished ES2015 exercises

7dc77a3

padEnd, flatten

4cdb916

flatten and flattenDeep

069f8f6

zip

c1c102d

flattenDeep, unzip

97f33d1

MiHHuynh added 2 commits August 7, 2017 17:14

finished hacker news clone

d3084ba

finished lodash exercises and recursion stringifyNumbers

19b05ab

MiHHuynh added 2 commits August 9, 2017 17:37

finished call apply bind exercises - ready for review

c39642a

finished parts 1 and 2 for prototypes exercises - ready for review

3284548

tigarcia reviewed Aug 11, 2017

View reviewed changes

tigarcia reviewed Aug 14, 2017

View reviewed changes

incomplete hack or snooze. Need to work on implementing signup/login …

a4e9826

…and favorites

		@@ -1,0 +1,55 @@
		function sumEvenArguments() {
		var arr = [].slice.call(arguments);

finished tests; working on implementing functions #39

Are you sure you want to change the base?

finished tests; working on implementing functions #39

Uh oh!

Conversation

MiHHuynh commented Aug 1, 2017

Uh oh!

MiHHuynh commented Aug 2, 2017

Uh oh!

mmmaaatttttt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MiHHuynh commented Aug 8, 2017

Uh oh!

tigarcia left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tigarcia left a comment

Choose a reason for hiding this comment

Uh oh!

MiHHuynh commented Aug 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

MiHHuynh commented Aug 14, 2017 •

edited

Loading