Testing Exercises Solutions #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt_exercises merging upstream
tigarcia
reviewed
Aug 11, 2017
|
|
||
| //Fix | ||
|
|
||
| var obj = { |
There was a problem hiding this comment.
One way to fix it is:
var obj = {
fullName: "Harry Potter",
person: {
sayHi: function() {
return "This person's name is " + this.fullName;
}
}
};
obj.person.sayHi = obj.person.sayHi.bind(obj);
| //3. Write a function called sumEvenArguments which takes all of the arguments passed to a function and returns the sum of the even ones. | ||
|
|
||
| function sumEvenArguments(){ | ||
| return [].slice.call(arguments).reduce(function(acc,next){ |
There was a problem hiding this comment.
I like the use of reduce!
| } | ||
| } | ||
|
|
||
| var person = { |
There was a problem hiding this comment.
this can be simplified to:
let person = {
fullName: "Harry Potter",
sayHi() {
setTimeout( () => console.log(`Your name is ${this.fullName}`), 1000);
}
}
|
|
||
| var arr = [1,2] | ||
| var [temp,temp2] = arr | ||
| [temp,temp2] = [temp2,temp] |
There was a problem hiding this comment.
var arr = [1,2];
arr = [arr[1], arr[2]];
|
|
||
|
|
||
| String.prototype.reverse = function(){ | ||
| let reverseStr = ""; |
There was a problem hiding this comment.
try splitting the string so that you don't use so much memory.
| } | ||
| } | ||
|
|
||
| Array.prototype.reduce = function(fn, startVal) { |
| } | ||
|
|
||
| Array.prototype.reduce = function(fn, startVal) { | ||
| let acc = startVal ? startVal : this[0]; |
There was a problem hiding this comment.
This is problematic because the startVal could be something that is falsy in javascript like 0 or "". The better approach would be to check the length of the arguments object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated testing.js and testingSpec.js with solutions