adding testing exercises #41
Conversation
elie
left a comment
elie
left a comment
There was a problem hiding this comment.
Watch your indentation, make sure you're using 2 spaces. Keep it up!
lodash_exercise/lodash.js
Outdated
| //_.drop([1, 2, 3]); | ||
| // => [2, 3] | ||
| function drop(array, n){ | ||
| if (n === undefined){ |
There was a problem hiding this comment.
Watch your indentation - 2 spaces please!
lodash_exercise/lodash.js
Outdated
|
|
||
|
|
||
| function fromPairs(array) { | ||
| if(array.length === 0) { |
There was a problem hiding this comment.
Much better on the indentation front!
lodash_exercise/lodash.js
Outdated
| } | ||
|
|
||
| function head(array){ | ||
| return array.shift(); |
There was a problem hiding this comment.
Watch your indentation - 2 spaces please!
lodash_exercise/lodash.js
Outdated
| } | ||
|
|
||
| function take(array, num){ | ||
| var newArr = []; |
There was a problem hiding this comment.
Watch your indentation - 2 spaces please!
lodash_exercise/lodash.js
Outdated
| function takeRight(array, num){ | ||
| if (num === 0) { | ||
| return []; | ||
| } else if (num >= array.length) { |
There was a problem hiding this comment.
Watch your indentation - this stuff will drive developers crazy :)
lodash_exercise/lodash.js
Outdated
| return (input.indexOf(value) != -1); | ||
| } | ||
| } else if (typeof input === "string") { | ||
| return (input.indexOf(value) != -1); |
lodash_exercise/lodash.js
Outdated
| } | ||
|
|
||
| function sample(arr){ | ||
| return arr[Math.floor(Math.random() * (arr.length))]; |
There was a problem hiding this comment.
No need for () around arr.length
| //contains(nestedObject, 44) // true | ||
| //contains(nestedObject, "foo") // false | ||
| function contains(obj, value) { | ||
| return collectStrings(obj).indexOf(value) !== -1; |
There was a problem hiding this comment.
Nice! Try to do this without using your collectStrings method :)
testing_exercise/testingSpec.js
Outdated
|
|
||
| // WRITE YOUR TESTS HERE! | ||
| describe("replaceWith", function () { | ||
| it("replaces a capital with a capital", function(){ |
There was a problem hiding this comment.
Watch your indentation - 2 spaces please.
| }); | ||
| //Write a function called mergeObjects which takes in two objects and return an object with the keys and values combined. If the second parameter has the same key - it should override first one. There is a built in function called Object.assign - research it, but do not use it, try to do this on your own! | ||
| describe("mergeObjects", function () { | ||
| it("returns an object with combined keys and values", function(){ |
There was a problem hiding this comment.
Indentation - 2 spaces please!
elie
left a comment
elie
left a comment
There was a problem hiding this comment.
Keep it up - try to finish these lodash exercises!
| var name = "Josie" | ||
| console.log("When " + name + " comes home, so good") | ||
| console.log(`When ${name} comes home, so good`); | ||
| //Steely Dan? |
| @@ -1,15 +1,88 @@ | |||
| window.addEventListener("load", function() { | |||
| //flow of what needs to happen: | |||
There was a problem hiding this comment.
Good start and your code looks clean so far. Try to add the seconds timer and stop the game after 30 seconds have passed.
|
|
||
|
|
||
| String.prototype.reverse = function () { | ||
| var result = []; |
There was a problem hiding this comment.
Good job using an array here.
| Function.prototype.bind = function (thisArg, ...outerArgs){ | ||
| var _this = this; | ||
| return function (...innerArgs) { | ||
| return _this.apply(thisArg, outerArgs.concat(innerArgs)); |
| } | ||
| } | ||
| } | ||
| ///yeah still need clarification on how this works ^ |
There was a problem hiding this comment.
Let me know if you want me to go over this with you. Looks like you go it right.
| } | ||
| } | ||
|
|
||
| function sayHi() { |
There was a problem hiding this comment.
you could change this to:
var obj = {
fullName: "Harry Potter",
person: {
sayHi: function(){
return "This person's name is " + this.fullName
}
}
}
obj.person.sayHi = obj.person.sayHi.bind(obj);
That way, you preserve the structure.
| } | ||
| var person2 = { | ||
| fullName: "Harry Potter", | ||
| sayHi: function(){ |
There was a problem hiding this comment.
this can be simplified more:
var person2 = {
fullName: "Harry Potter",
sayHi() {
setTimeout( () => console.log(`Your name is ${this.fullName}`), 1000)
}
}
| } | ||
|
|
||
| function inRange(){ | ||
| function inRange() { |
There was a problem hiding this comment.
Try to work on the rest of these when you get a chance.
| Function.prototype.bind = function (thisArg, ...outerArgs){ | ||
| var _this = this; | ||
| return function (...innerArgs) { | ||
| return _this.apply(thisArg, outerArgs.concat(innerArgs)); |
|
Hey Sarah, have you made progress on the hacker snooze app? I didn't see any changes related to that in your PR |
3 participants
No description provided.