Merged
Conversation
Contributor
Author
|
pretty sure this is related to us creating lots of objects (sure) but also how we refer to native classes from within the cpp bindings... so we used to create these references once. and remember them. but they're not thread safe, so we now grab then on the fly. we do no cleanup here at the moment e.g. jclass getClass(const char *name)
{
return static_cast<jclass>(getJNIEnv()->FindClass(name));
}https://stackoverflow.com/questions/20917777/jni-error-local-reference-table-overflow-512-entries |
02f5022 to
a5aabab
Compare
Contributor
Author
|
there are still some display issues, as not all blend modes are supported in < 29 & multiply seems to behave grossly different, but this enables compatibility! |
mjtalbot
added a commit
that referenced
this pull request
Jun 26, 2022
add changed needed to lower sdk to 21
mjtalbot
added a commit
that referenced
this pull request
Jun 26, 2022
add changed needed to lower sdk to 21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft because it does not work (yet?)
(but this resolves other issues we would run into along the way to api v 21)
we run into this issue: