Skip to content

Initialize pointers to null#230

Merged
umberto-sonnino merged 1 commit intomasterfrom
init_with_null
Feb 2, 2022
Merged

Initialize pointers to null#230
umberto-sonnino merged 1 commit intomasterfrom
init_with_null

Conversation

@umberto-sonnino
Copy link
Copy Markdown
Contributor

Fixes a crash with invisible Views. JNIRenderer was initialized but its corresponding window surface wasn't. The destructor would almost always try to delete a missing mSkRenderer.

@umberto-sonnino umberto-sonnino added the bug Something isn't working label Feb 2, 2022
Copy link
Copy Markdown
Contributor

@mjtalbot mjtalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@umberto-sonnino umberto-sonnino merged commit 2d1aae9 into master Feb 2, 2022
@umberto-sonnino umberto-sonnino deleted the init_with_null branch February 2, 2022 13:20
mjtalbot pushed a commit that referenced this pull request Jun 26, 2022
mjtalbot pushed a commit that referenced this pull request Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants