feat: ViewModelImageProperty#40
Merged
Merged
Conversation
mfazekas
force-pushed
the
mfazekas/rive-image-data-bind-property
branch
2 times, most recently
from
91de609 to
ce6bb67
Compare
mfazekas
force-pushed
the
mfazekas/referenced-asset-rive-image
branch
from
4f55287 to
48bb684
Compare
mfazekas
force-pushed
the
mfazekas/rive-image-data-bind-property
branch
from
ce6bb67 to
b29d48d
Compare
HayesGordon
reviewed
Nov 28, 2025
mfazekas
force-pushed
the
mfazekas/referenced-asset-rive-image
branch
from
48bb684 to
3ba8a15
Compare
mfazekas
force-pushed
the
mfazekas/rive-image-data-bind-property
branch
from
b29d48d to
147591d
Compare
mfazekas
force-pushed
the
mfazekas/referenced-asset-rive-image
branch
2 times, most recently
from
237ac42 to
d7af261
Compare
mfazekas
force-pushed
the
mfazekas/rive-image-data-bind-property
branch
from
147591d to
30fc73e
Compare
mfazekas
force-pushed
the
mfazekas/rive-image-data-bind-property
branch
from
30fc73e to
80c4c9e
Compare
mfazekas
changed the base branch from
mfazekas/referenced-asset-rive-image
to
main
HayesGordon
reviewed
Dec 4, 2025
HayesGordon
reviewed
Dec 8, 2025
| } | ||
|
|
||
| /// Protocol for Rive property types with void listeners (Trigger, Image) | ||
| protocol RivePropertyWithVoidListeners: AnyObject { |
HayesGordon
approved these changes
Dec 8, 2025
mfazekas
added a commit
that referenced
this pull request
Dec 9, 2025
* fix: regenerate nitrogen files for nitro-modules 0.31.10 PR #40 was merged with nitrogen files generated by nitro-modules@0.31.8. PR #64 upgraded to nitro-modules@0.31.10 but was developed before PR #40 merged, so it didn't regenerate ViewModelImageProperty. The new nitro-modules version requires JNICallable.hpp include. * fix(android): fix HybridViewModelImageProperty addListener type mismatch The listeners property is MutableList<(Unit) -> Unit> but onChanged is () -> Unit. Wrap in lambda to match the expected signature, same pattern as TriggerProperty. * fix(android): fix updateAsset call signature after PR #63 refactor PR #63 changed updateAsset from 3 args to 2 args (removed context) in ReferencedAssetLoader but missed updating the call site in HybridRiveFile. * fix(ci): force turbo rebuild on stale cache fallback match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Image type data binding - set only
Fixes: #9