Skip to content

update max time in NeverSchedule.Next method#760

Merged
bgentry merged 3 commits intoriverqueue:masterfrom
krhubert:master
Feb 15, 2025
Merged

update max time in NeverSchedule.Next method#760
bgentry merged 3 commits intoriverqueue:masterfrom
krhubert:master

Conversation

@krhubert
Copy link
Copy Markdown
Contributor

closes #759

Copy link
Copy Markdown
Contributor

@bgentry bgentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the fix and welcome back @krhubert 🙏🏻 could you please add a “fixed” changelog entry for this? We plan to ship a release today and can get this included.

Comment thread periodic_job_test.go Outdated
@krhubert
Copy link
Copy Markdown
Contributor Author

Good to see you @bgentry ! I added a note to changelog's fixed section

Comment thread CHANGELOG.md Outdated
@bgentry
Copy link
Copy Markdown
Contributor

bgentry commented Feb 15, 2025

One final request @krhubert, could you please add yourself to the CLA when you have a minute? I was thinking you were already on there but apparently not! https://github.com/riverqueue/rivercla

@bgentry bgentry merged commit f2f2f0e into riverqueue:master Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NeverSchedule: invalid max time time causes periodic job to run with no interval

2 participants