Skip to content

Conversation

@nttg8100
Copy link
Member

@nttg8100 nttg8100 commented Dec 1, 2025

  • Added seed to control randomness in train test split
  • Refactored python project
  • Fixed delta adding data types

@nttg8100 nttg8100 requested a review from Copilot December 1, 2025 16:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Python project structure and fixes several data handling issues. The main focus is adding seed control for reproducibility, consolidating package configuration, and fixing type handling in image normalization.

Key Changes

  • Added seed parameter to control randomness in train-test splits for reproducible results
  • Fixed float64 type casting issue in delta normalization to prevent data type errors
  • Consolidated package configuration by migrating from Poetry to Pixi/hatchling build system

Reviewed changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
smartsensor/process/normalize.py Fixed data type conversion and reformatted multi-line statements
smartsensor/model/split_data.py Updated docstring, removed unused variable, and added capitalization to comment
smartsensor/model/partition.py Removed entire deprecated file containing old train-test split implementation
smartsensor/model/metric.py Updated return type annotation and reformatted multi-line expressions
smartsensor/model/formula.py Removed deprecated custom prediction function
smartsensor/main.py Added seed parameter with logging and reformatted option definitions
smartsensor/e2e.py Added numpy import and seed initialization for reproducibility
pyproject.toml Migrated from Poetry to Pixi/hatchling build system with updated dependencies
pixi.toml Removed old Pixi configuration file (replaced by pyproject.toml)
README.md Fixed typo, restructured documentation with usage examples and dataset citations
.gitattributes Added configuration for pixi.lock file handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nttg8100 nttg8100 merged commit 1312f4c into v1.1.0 Dec 1, 2025
@nttg8100 nttg8100 deleted the revised_menuscript_v1 branch December 29, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants