Skip to content

feat: add durable storage MVP#267

Merged
NathanFlurry merged 1 commit into
mainfrom
05-10-feat_add_durable_storage_mvp
May 25, 2024
Merged

feat: add durable storage MVP#267
NathanFlurry merged 1 commit into
mainfrom
05-10-feat_add_durable_storage_mvp

Conversation

@MasterPtato

@MasterPtato MasterPtato commented May 10, 2024 •
edited by Blckbrry-Pi
Loading

Copy link
Copy Markdown
Contributor

Resolves OGBE-97

@MasterPtato MasterPtato requested a review from NathanFlurry May 10, 2024 23:48
@MasterPtato Graphite App

MasterPtato commented May 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite Graphite

@MasterPtato MasterPtato requested a review from Blckbrry-Pi May 10, 2024 23:49
@MasterPtato MasterPtato force-pushed the 05-10-feat_add_durable_storage_mvp branch from f6e97b3 to e4cabfa Compare May 13, 2024 23:38
Blckbrry-Pi
Blckbrry-Pi previously requested changes May 15, 2024
View reviewed changes

@Blckbrry-Pi Blckbrry-Pi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall!

I don't know too much about durable storage and the idea behind it, but I think the Deno implementation is pretty severely lacking without persistence.

Additionally, most of the comments I left on the Deno impl also apply to the CF impl.

Again, I apologize for advocating for more typescript complexity, but if instantiating a Durable it isn't disallowed by the type system, we NEED to explicitly document that. Module authors will definitely do that by accident.

Additionally, I'm not completely sure what the "point" of the durable storage is. Is that not what postgres and prisma are for?

Comment thread src/runtime/durable.ts Outdated
Comment thread src/runtime/context.ts Outdated
Comment thread tests/basic/modules/foo/scripts/call_self.ts
Comment thread src/runtime/durable_cf.ts Outdated
Comment thread src/runtime/durable.ts Outdated
Comment thread src/runtime/durable.ts Outdated
Comment thread src/runtime/durable.ts Outdated
@linear

linear Bot commented May 15, 2024

Copy link
Copy Markdown

OGBE-97 OpenGB Durable Storage

@NathanFlurry

NathanFlurry commented May 15, 2024

Copy link
Copy Markdown
Member

@MasterPtato would you rather me wait until the next iteration is ready to go or review this now?

@MasterPtato MasterPtato marked this pull request as draft May 16, 2024 16:58
@MasterPtato Graphite App

MasterPtato commented May 16, 2024

Copy link
Copy Markdown
Contributor Author

@Blckbrry-Pi @NathanFlurry this was meant to be a draft sorry

@MasterPtato MasterPtato force-pushed the 05-10-feat_add_durable_storage_mvp branch from e4cabfa to c6d5e6e Compare May 16, 2024 21:40
@MasterPtato MasterPtato marked this pull request as ready for review May 16, 2024 22:20
@MasterPtato MasterPtato requested a review from Blckbrry-Pi May 16, 2024 22:20
@MasterPtato MasterPtato force-pushed the 05-10-feat_add_durable_storage_mvp branch from c6d5e6e to 4ff9bac Compare May 16, 2024 22:23
@Blckbrry-Pi Blckbrry-Pi force-pushed the 05-10-feat_add_durable_storage_mvp branch from 4ff9bac to 832f88c Compare May 21, 2024 18:29
@NathanFlurry NathanFlurry force-pushed the 05-10-feat_add_durable_storage_mvp branch from 832f88c to ec33168 Compare May 25, 2024 03:22
@NathanFlurry NathanFlurry changed the base branch from main to 05-24-fix_server_update_request_handler_to_work_for_cloudflare_workers May 25, 2024 03:22
@NathanFlurry NathanFlurry mentioned this pull request May 25, 2024
Merged
@NathanFlurry

NathanFlurry commented May 25, 2024

Copy link
Copy Markdown
Member

@MasterPtato merging this since it's blocking other things. let's make sure this gets cleaned up at some point soon.

@NathanFlurry Graphite App

NathanFlurry commented May 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Merge activity

  • May 24, 11:41 PM EDT: @NathanFlurry started a stack merge that includes this pull request via Graphite.
  • May 24, 11:42 PM EDT: Graphite rebased this pull request as part of a merge.
  • May 24, 11:43 PM EDT: @NathanFlurry merged this pull request with Graphite.

Base automatically changed from 05-24-fix_server_update_request_handler_to_work_for_cloudflare_workers to main May 25, 2024 03:41
@NathanFlurry NathanFlurry force-pushed the 05-10-feat_add_durable_storage_mvp branch from ec33168 to 75fd0dc Compare May 25, 2024 03:42
@NathanFlurry NathanFlurry merged commit 7d2d7be into main May 25, 2024
@NathanFlurry NathanFlurry deleted the 05-10-feat_add_durable_storage_mvp branch May 25, 2024 03:43
@github-actions github-actions Bot mentioned this pull request May 25, 2024
Merged
@NathanFlurry NathanFlurry mentioned this pull request Jul 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanFlurry NathanFlurry Awaiting requested review from NathanFlurry
@Blckbrry-Pi Blckbrry-Pi Awaiting requested review from Blckbrry-Pi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MasterPtato @NathanFlurry @Blckbrry-Pi