Skip to content

refactor(site): improve readability#2271

Closed
jog1t wants to merge 1 commit intomainfrom
03-25-refactor_site_improve_readability
Closed

refactor(site): improve readability#2271
jog1t wants to merge 1 commit intomainfrom
03-25-refactor_site_improve_readability

Conversation

@jog1t
Copy link
Copy Markdown
Contributor

@jog1t jog1t commented Mar 25, 2025

Changes

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Mar 25, 2025 •
edited
Loading

Deploying rivet-hub with  Cloudflare Pages  Cloudflare Pages

Latest commit: e8f8319
Status: ✅  Deploy successful!
Preview URL: https://77b1af16.rivet-hub-7jb.pages.dev
Branch Preview URL: https://03-25-refactor-site-improve.rivet-hub-7jb.pages.dev

View logs

@jog1t Graphite App
Copy link
Copy Markdown
Contributor Author

jog1t commented Mar 25, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t marked this pull request as ready for review March 25, 2025 16:12
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Mar 25, 2025 •
edited
Loading

Merge activity

  • Mar 25, 12:13 PM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 25, 12:14 PM EDT: CI is running for this pull request on a draft pull request (#2272) due to your merge queue CI optimization settings.
  • Mar 25, 12:15 PM EDT: A user merged this pull request with the Graphite merge queue via draft PR: #2272.

graphite-app Bot pushed a commit that referenced this pull request Mar 25, 2025
@jog1t
refactor(site): improve readability (#2271)
1318c02 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
greptile-apps[bot]
greptile-apps Bot reviewed Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements layout and styling improvements across the blog section of the Rivet site, focusing on better readability and consistent spacing.

  • Added new blog layout component with FancyHeader and moved code block metadata to top for better visual hierarchy
  • Introduced responsive max-width constraints for technical articles (1000px) vs regular blog posts
  • Added --header-height CSS variable (5rem) for consistent spacing across layouts
  • Improved table of contents scrolling with lg:max-h-content and proper viewport height calculations
  • Updated typography styles to use --muted-foreground for better content hierarchy

8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

Comment thread site/src/app/(v2)/(blog)/blog/layout.tsx
@@ -0,0 +1,10 @@
import { FancyHeader } from "@/components/v2/FancyHeader";

export default function Layout({ children }) {
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Missing TypeScript type definition for children prop

Suggested change
export default function Layout({ children }) {
export default function Layout({ children }: { children: React.ReactNode }) {

Comment thread site/tailwind.v2.config.js
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Mar 25, 2025

Graphite Automations

"Test" took an action on this PR • (03/25/25)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

@graphite-app graphite-app Bot closed this Mar 25, 2025
@graphite-app graphite-app Bot deleted the 03-25-refactor_site_improve_readability branch March 25, 2025 16:15
@github-actions github-actions Bot mentioned this pull request Mar 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jog1t jog1t

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jog1t