chore(api-actor): handle no edge regions gracefully #2318
Closed
+113
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-hub with
|
| Latest commit: |
5bcfed5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c0f6be84.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://04-07-chore-api-actor-handle.rivet-hub-7jb.pages.dev |
This was referenced Apr 7, 2025
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 7, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves error handling for missing edge regions by filtering datacenters across actor endpoints before making API calls, ensuring that only datacenters with valid worker and guard pools are contacted.
- Updated packages/core/api/actor/src/route/logs.rs to bail early with a clear error when no valid datacenters are found.
- Modified multiple endpoints in packages/core/api/actor/src/route/actors.rs to use the new filtering logic.
- Refined build prewarm and error aggregation in packages/core/api/actor/src/route/builds.rs.
- Enhanced configuration and error propagation in packages/common/config/src/config/server/rivet/mod.rs and packages/core/api/actor/src/utils.rs.
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+217
to
+223
| /// If there are multipe types of servers in a cluster. This affects how fan-out requests are | ||
| /// sent to servers. | ||
| pub fn has_multiple_server_types(&self) -> bool { | ||
| match self.auth.access_kind { | ||
| AccessKind::Development => false, | ||
| AccessKind::Public | AccessKind::Private => true, | ||
| } |
There was a problem hiding this comment.
style: Typo in doc comment: 'multipe' should be 'multiple'.
Suggested change
| /// If there are multipe types of servers in a cluster. This affects how fan-out requests are | |
| /// sent to servers. | |
| pub fn has_multiple_server_types(&self) -> bool { | |
| match self.auth.access_kind { | |
| AccessKind::Development => false, | |
| AccessKind::Public | AccessKind::Private => true, | |
| } | |
| ```suggestion /// If there are multiple types of servers in a cluster. This affects how fan-out requests are | |
| /// sent to servers. | |
| pub fn has_multiple_server_types(&self) -> bool { | |
| match self.auth.access_kind { | |
| AccessKind::Development => false, | |
| AccessKind::Public | AccessKind::Private => true, | |
| } |
Deploying rivet with
|
| Latest commit: |
5bcfed5
|
| Status: | 🚫 Build failed. |
Deploying rivet-studio with
|
| Latest commit: |
5bcfed5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://83e9fb06.rivet-studio.pages.dev |
| Branch Preview URL: | https://04-07-chore-api-actor-handle.rivet-studio.pages.dev |
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
04-07-chore_api-actor_handle_no_edge_regions_gracefully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes