fix: make copy buttons copy again #2379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet-studio with
|
| Latest commit: |
3e59112
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90e46b05.rivet-studio.pages.dev |
| Branch Preview URL: | https://04-24-fix-make-copy-buttons.rivet-studio.pages.dev |
Contributor
Author
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
jog1t
force-pushed
the
04-24-fix_make_copy_buttons_copy_again
branch
from
3e59112 to
02ea955
Compare
Contributor
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Apr 24, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> Closes FRONT-684 ## Changes <!-- If there are frontend changes, please include screenshots. -->
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed code copying functionality in MDX components by improving the selection and handling of code blocks in both grouped and non-grouped contexts.
- Added
data-code-groupattribute toCodeGroupandprecomponents for proper code block identification - Enhanced
CopyCodeTriggerto first check for active tab's code within groups before falling back to standalone code blocks - Improved file display styling by converting plain text to
Badgecomponent with icon - Optimized margins and spacing for better visual hierarchy in code groups
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet-hub with
|
| Latest commit: |
3e59112
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ce96ad87.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://04-24-fix-make-copy-buttons.rivet-hub-7jb.pages.dev |
Contributor
Graphite Automations"Test" took an action on this PR • (04/24/25)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FRONT-684
Changes