Skip to content

Clean up dead code in OSS #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Clean up dead code in OSS #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions gen/secrets.baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@
"path": "detect_secrets.filters.common.is_baseline_file",
"filename": "gen/secrets.baseline.json"
},
{
"path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
"min_level": 2
},
{
"path": "detect_secrets.filters.gibberish.should_exclude_secret",
"limit": 3.7
Expand Down Expand Up @@ -186,7 +190,7 @@
"filename": "svc/pkg/email-verification/ops/create/src/lib.rs",
"hashed_secret": "670988a3ad6d12dc80cb21cf98d44dd470e653d1",
"is_verified": false,
"line_number": 107
"line_number": 108
}
],
"svc/pkg/telemetry/standalone/beacon/src/lib.rs": [
Expand All @@ -199,5 +203,5 @@
}
]
},
"generated_at": "2023-11-09T20:53:32Z"
"generated_at": "2024-01-08T08:54:04Z"
}
10 changes: 4 additions & 6 deletions lib/global-error/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ impl GlobalError {
pub fn documentation(&self) -> Option<&str> {
match self {
GlobalError::Internal { .. } => None,
GlobalError::BadRequest { code, .. } => Some(formatted_error::parse(code).documentation()),
GlobalError::BadRequest { code, .. } => {
Some(formatted_error::parse(code).documentation())
}
}
}

Expand Down Expand Up @@ -162,11 +164,7 @@ impl From<GlobalError> for chirp::response::Err {
retry_immediately: _,
} => chirp::response::Err {
kind: Some(chirp::response::err::Kind::Internal(
chirp::response::err::Internal {
ty,
message,
debug,
},
chirp::response::err::Internal { ty, message, debug },
)),
},
GlobalError::BadRequest {
Expand Down
19 changes: 0 additions & 19 deletions svc/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion svc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ members = [
"api/portal",
"api/route",
"api/status",
"pkg/analytics/worker",
"pkg/build/ops/create",
"pkg/build/ops/get",
"pkg/build/ops/list-for-game",
Expand Down
7 changes: 0 additions & 7 deletions svc/pkg/analytics/db/analytics/Service.toml
View file
Open in desktop

This file was deleted.

Empty file removed svc/pkg/analytics/db/analytics/migrations/20200101000000_init.down.sql
View file
Open in desktop
Empty file.
13 changes: 0 additions & 13 deletions svc/pkg/analytics/db/analytics/migrations/20200101000000_init.up.sql
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions svc/pkg/analytics/types/msg/event-create.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ message Message {
message Event {
reserved 5, 6, 7, 8;

// ID of event. This is used as the primary key in ClickHouse for deduplication.
rivet.common.Uuid event_id = 10;

// Override the timestamp the event was emitted at.
optional int64 ts = 9;

Expand Down
25 changes: 0 additions & 25 deletions svc/pkg/analytics/worker/Cargo.toml
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions svc/pkg/analytics/worker/Service.toml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion svc/pkg/analytics/worker/src/lib.rs
View file
Open in desktop

This file was deleted.

91 changes: 0 additions & 91 deletions svc/pkg/analytics/worker/src/workers/event_create.rs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions svc/pkg/analytics/worker/src/workers/mod.rs
View file
Open in desktop

This file was deleted.

106 changes: 0 additions & 106 deletions svc/pkg/analytics/worker/tests/event_create.rs
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions svc/pkg/captcha/ops/request/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ async fn handle(
msg!([ctx] analytics::msg::event_create() {
events: vec![
analytics::msg::event_create::Event {
event_id: Some(Uuid::new_v4().into()),
name: "captcha.needs_verification".into(),
properties_json: Some(serde_json::to_string(&json!({
"user_id": user_id,
Expand Down
1 change: 1 addition & 0 deletions svc/pkg/captcha/ops/verify/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ async fn handle(
msg!([ctx] analytics::msg::event_create() {
events: vec![
analytics::msg::event_create::Event {
event_id: Some(Uuid::new_v4().into()),
name: if success { "captcha.success" } else { "captcha.fail" }.into(),
properties_json: Some(serde_json::to_string(&json!({
"user_id": user_id,
Expand Down
1 change: 1 addition & 0 deletions svc/pkg/cdn/ops/namespace-domain-create/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ async fn handle(
msg!([ctx] analytics::msg::event_create() {
events: vec![
analytics::msg::event_create::Event {
event_id: Some(Uuid::new_v4().into()),
name: "cdn.domain.update".into(),
properties_json: Some(serde_json::to_string(&json!({
"developer_team_id": developer_team_id,
Expand Down
Loading