Skip to content

chore(rivetkit): log close code when client ws closes #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

chore(rivetkit): log close code when client ws closes #3361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions rivetkit-typescript/packages/rivetkit/src/client/actor-conn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,17 +563,21 @@ enc
// TODO: Handle queue
// TODO: Reconnect with backoff

// Reject open promise
if (this.#onOpenPromise) {
this.#onOpenPromise.reject(new Error("Closed"));
}

// We can't use `event instanceof CloseEvent` because it's not defined in NodeJS
//
// These properties will be undefined
const closeEvent = event as CloseEvent;
const wasClean = closeEvent.wasClean;

// Reject open promise
if (this.#onOpenPromise) {
this.#onOpenPromise.reject(
new Error(
`websocket closed with code ${closeEvent.code}: ${closeEvent.reason}`,
),
);
}

logger().info({
msg: "socket closed",
code: closeEvent.code,
Expand Down
Loading