Skip to content

Validate user cannot run as root #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024
Merged

Validate user cannot run as root #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions svc/pkg/mm/worker/src/workers/lobby_create/scripts/setup_oci_bundle.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ EOF
log "Templating config.json"
OVERRIDE_CONFIG="$NOMAD_ALLOC_DIR/oci-bundle-config.overrides.json"
mv "$OCI_BUNDLE_PATH/config.json" "$OVERRIDE_CONFIG"


# Template new config
jq "
.process.args = $(jq '.process.args' $OVERRIDE_CONFIG) |
.process.env = $(jq '.process.env' $OVERRIDE_CONFIG) + .process.env |
Expand All @@ -75,5 +78,15 @@ jq "
}]
" "$NOMAD_ALLOC_DIR/oci-bundle-config.base.json" > "$OCI_BUNDLE_PATH/config.json"

# Validate config
if [ "$(jq '.process.user.uid' "$OVERRIDE_CONFIG")" == "0" ]; then
log "Container is attempting to run as root user"
exit 1
fi
if [ "$(jq '.process.user.gid' "$OVERRIDE_CONFIG")" == "0" ]; then
log "Container is attempting to run as root group"
exit 1
fi

log "Finished setting up OCI bundle"