[Graphite MQ] Draft PR GROUP:spec_f563cb (PRs 3533, 3534)

[graphite-app]

This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.

The following PRs are included in this draft PR:

• #3533
• #3534

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-inspector	Error			Nov 24, 2025 8:09am
rivet-site	Error			Nov 24, 2025 8:09am
rivetkit-serverless	Error			Nov 24, 2025 8:09am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Nov 24, 2025 8:09am

[claude]

PR Review Summary

This PR combines two PRs from the Graphite merge queue:

• chore(examples): fix types #3533: chore(examples): fix types
• docs: update docs #3534: docs: update docs

Overview

The changes include:

1. Version bump to 2.0.25-rc.1 across all packages
2. New examples: cloudflare-workers-inline-client and counter-next-js
3. Significant documentation updates
4. Type fixes in existing examples
5. OpenAPI schema updates

---

Code Quality & Best Practices

✅ Good

• Clean example code: The new examples (cloudflare-workers-inline-client, counter-next-js) are well-structured and demonstrate good patterns for RivetKit usage
• Type-safe client usage: Proper use of typeof registry for type inference in clients
• Consistent patterns: The counter registry patterns are consistent across examples
• Clear separation of concerns: The inline client example properly separates the registry, handler, and client scripts

⚠️ Minor Suggestions

1. examples/cloudflare-workers-inline-client/src/index.ts:36: Debug console.log("URL", url.toString()) should probably be removed or converted to proper logging before production use

2. examples/counter-next-js/src/components/Counter.tsx:26: The counter.connection.getCount() call in useEffect could potentially race with the newCount event. Consider if initial state sync is needed or if you should wait for the first event.

3. examples/kitchen-sink/src/backend/actors/websocket.ts:3: The function uses c: any - consider adding proper typing for better IDE support and type safety

---

Potential Bugs or Issues

⚠️ Items to Verify

1. Wrangler migration config change (examples/cloudflare-workers/wrangler.json):

   - "new_classes": ["ActorHandler"]
   + "new_sqlite_classes": ["ActorHandler"]

   This is a breaking change for existing deployments. Ensure this is intentional and document the migration path for users upgrading.

2. Counter state simplified (examples/cloudflare-workers/src/registry.ts):

   - state: { count: 0, connectionCount: 0, messageCount: 0 },
   + state: { count: 0 },

   The removal of connectionCount and messageCount from the counter state is fine if these were unused, but verify no client code depended on them.

---

Performance Considerations

✅ No significant performance concerns identified. The changes are primarily documentation and examples.

---

Security Concerns

✅ No security issues identified. The examples properly demonstrate:

• Token-based authentication configuration (NEXT_PUBLIC_RIVET_TOKEN)
• Namespace isolation (NEXT_PUBLIC_RIVET_NAMESPACE)
• Proper environment variable handling

---

Test Coverage

⚠️ This PR is primarily examples and documentation, which typically don't require test coverage. However:

1. Client test scripts: Good inclusion of client-http.ts and client-rivetkit.ts scripts in the cloudflare-workers-inline-client example for manual testing
2. Connect script: The connect.ts script in counter-next-js provides a good way to test the actor functionality

Consider adding integration tests for the examples in CI if not already present.

---

Documentation Changes

The documentation updates appear extensive and helpful:

• New architecture documentation with images
• Updated authentication docs
• New pages for design-patterns.mdx, destroy.mdx, request-handler.mdx, websocket-handler.mdx
• URL corrections from /deploy/ to /connect/ paths in README.md

---

Summary

Recommendation: ✅ Approve with minor suggestions

This is a solid documentation and examples update. The code is clean, follows good patterns, and improves the developer experience. The main items to verify are:

1. The wrangler migration change from new_classes to new_sqlite_classes - ensure this is documented for existing users
2. Consider removing the debug console.log in the cloudflare-workers-inline-client example

---

🤖 Generated with Claude Code