Skip to content

Upgrade async-nats #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Upgrade async-nats #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- **pools** Decrease SQLx `idle_timeout` to 3 minutes
- **pools** Set ClickHouse `idle_timeout` to 15 seconds
- **api-helper** Box path futures for faster compile times
- Upgrade `async-nats`

### Security

Expand Down
2 changes: 1 addition & 1 deletion lib/pools/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ authors = ["Rivet Gaming, LLC <developer@rivet.gg>"]
license = "Apache-2.0"

[dependencies]
async-nats = "0.31"
async-nats = "0.33"
clickhouse = { version = "0.11.2" }
funty = "=1.1.0" # Fixes issue with sqlx dependency, see https://github.com/bitvecto-rs/bitvec/issues/105#issuecomment-778570981
global-error = { path = "../global-error" }
Expand Down
3 changes: 0 additions & 3 deletions lib/pools/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ async fn nats_from_env(client_name: String) -> Result<Option<NatsPool>, Error> {
async_nats::ConnectOptions::new()
};
options = options
// Flush frequently since we don't flush messages
// TODO: Lower this interval in development to reduce overhead
.flush_interval(Duration::from_millis(50))
.client_capacity(256)
.subscription_capacity(8192)
.event_callback({
Expand Down
13 changes: 6 additions & 7 deletions svc/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.