chore(engine): improve logging around cross-dc requests

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Ignored			Dec 9, 2025 10:22am
rivet-inspector	Ignored	Preview		Dec 9, 2025 10:22am
rivet-site	Ignored	Preview		Dec 9, 2025 10:22am
rivetkit-serverless	Skipped			Dec 9, 2025 10:22am

[NathanFlurry]

• fix(guard): fix routing gateway cross-region #3611
• fix(api-public): fix routing get or create requests cross-region #3610
• chore(engine): improve logging around cross-dc requests #3609 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review

This PR improves logging around cross-datacenter requests. Overall, the changes are well-structured and follow good practices. Here's my feedback:

✅ Strengths

1. Better Error Context: The new send_request helper function provides consistent error context with datacenter label and URL information across both request functions.

2. Improved Observability: Enhanced error messages in reqwest_to_axum_response and parse_response now include:

   • HTTP status codes
   • Ray IDs for request tracing
   • Response body content for debugging

3. Consistent Pattern: Code deduplication by extracting send_request helper reduces maintenance burden.

4. Proper Error Handling: The early return on non-success status in reqwest_to_axum_response (lines 183-188) prevents invalid responses from being passed through.

🔍 Observations

1. Error Message Clarity (line 185): The error message says "remote dc returned error" but this might be slightly misleading if it's a network issue vs. an application error. However, this is minor since the status code provides context.

2. String Allocation (lines 48, 86): url.to_string() is called before the request to preserve the URL for error logging. This is a reasonable trade-off for better error messages.

3. Structured Logging Compliance: ✅ The existing tracing::debug! calls at lines 46 and 84 correctly use structured logging with %method and %url rather than formatting into the message string, following the CLAUDE.md guidelines.

4. Error Context Formatting: The error messages follow good practices by providing actionable debugging information (dc label, URL, ray_id, response body).

💡 Suggestions

Minor: Consider truncating response bodies in error messages

Large response bodies could make logs noisy. Consider truncating the body in error messages:

let body_preview = if body_text.len() > 500 {
    format!("{}... (truncated)", &body_text[..500])
} else {
    body_text.to_string()
};

However, this is truly optional - in distributed system debugging, having the full response body is often invaluable.

🎯 Conclusion

Approved ✓

This is a solid improvement to error handling and observability. The changes:

• Follow the repository's error handling patterns
• Improve debugging capabilities significantly
• Maintain code quality and consistency
• Don't introduce security, performance, or correctness issues

The minor suggestions above are truly optional - the PR is ready to merge as-is.

[pkg-pr-new]

More templates

• actor-actions
• example-ai-agent
• example-ai-and-user-generated-actors-freestyle
• chat-room
• chat-room-next-js
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-cloudflare-workers-inline-client
• cross-actor-actions
• example-cursors
• example-cursors-raw-websocket
• custom-serverless
• example-deno
• example-sqlite
• example-elysia
• example-express
• example-hono
• hono-bun
• hono-react
• example-kitchen-sink
• multi-region
• native-websockets
• next-js
• node
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• scheduling
• state
• example-stream
• example-trpc

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3609

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3609

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3609

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3609

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3609

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3609

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3609

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3609

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3609

commit: 662e787

[graphite-app]

Merge activity

• Dec 12, 1:57 AM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Dec 12, 1:58 AM UTC: CI is running for this pull request on a draft pull request (#3639) due to your merge queue CI optimization settings.
• Dec 12, 1:58 AM UTC: Merged by the Graphite merge queue via draft PR: #3639.