chore: clean up errors

[MasterPtato]

No description provided.

[MasterPtato]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(pegboard): cache none runner pool errors too #3899
• fix(engine-runner): handle shutdown close codes correctly #3896
• chore(gas): add overview and history docs #3879
• fix(otel): enrich http traces #3878
• fix(guard): clean up guard #3862
• fix: add ready_chunks to worker bumps, bumps per tick metric #3855
• fix(epoxy): add metrics #3847
• chore: clean up errors #3846 👈 (View in Graphite)
• fix(pb): have restart policy actors sleep after pending for too long #3837
• fix: set failure reason regardless of crash policy #3835
• feat: add metrics to pb, guard #3815
• fix: clear all pending signals after workflow complete #3798
• fix: remove pending actors metric, fix actor error tracker, engine runner error print #3797
• chore(engine): add support for epoxy debugging #3794
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review - PR #3846: chore: clean up errors

Summary

This PR cleans up the error handling structure by:

1. Removing unused guard error artifacts (actor_destroyed and actor_not_found)
2. Moving the Datacenter error from api-public to api-util for better code organization
3. Updating test errors to use the test group instead of domain-specific groups
4. Improving error handling patterns in test code

✅ Positive Changes

1. Better Code Organization

• Moving Datacenter::NotFound from api-public/src/errors.rs to api-util/src/errors.rs improves modularity since it's used by multiple packages
• Making errors module public in api-util allows proper access from api-public

2. Cleanup of Unused Errors

• Removing guard.actor_destroyed.json and guard.actor_not_found.json artifacts is appropriate - these errors are handled by pegboard::errors::Actor::NotFound (line 8-9 in engine/packages/pegboard/src/errors.rs)
• The guard proxy service still references these error codes in status code mapping (lines 2530-2531 in proxy_service.rs), but this appears to be for handling errors that might come from pegboard

3. Test Improvements

• Renaming test error groups from domain-specific (api, namespace) to test makes it clearer these are test fixtures
• The streaming_response.rs changes improve code clarity:
  • Using early return instead of assigning to Ok() makes control flow more explicit
  • Replacing bail!("bad path") with Err(anyhow::anyhow!("bad path")) is more explicit and follows the pattern from CLAUDE.md (avoiding glob imports from anyhow)

🔍 Observations

1. Error Artifact Files
The error artifacts in engine/artifacts/errors/ are auto-generated from the #[derive(RivetError)] macros. The test error artifacts were properly renamed:

• api.rate_limited.json → test.api_rate_limited.json
• namespace.invalid_name.json → test.namespace_invalid_name.json

2. Consistent Error Handling Pattern
The changes follow the established pattern in CLAUDE.md:

• Using #[derive(RivetError)] with proper group/code structure
• Returning anyhow errors from failable functions
• Not glob-importing from anyhow

📋 Minor Suggestions

1. Consider Removing Dead Code
The proxy_service.rs still has status code mappings for the deleted errors:

("guard", "actor_not_found") => StatusCode::NOT_FOUND,
("guard", "actor_destroyed") => StatusCode::NOT_FOUND,

If these errors are truly unused, consider removing these mappings as well. However, if they're still possible from pegboard or other services, keeping them for defensive error handling is fine.

2. Error Message Clarity
In streaming_response.rs:256, the error message "bad path" could be more descriptive for debugging purposes:

Err(anyhow::anyhow!("bad path: {}", path))

✅ Code Quality Assessment

• Best Practices: ✅ Follows Rust and project conventions
• Potential Bugs: ✅ None identified
• Performance: ✅ No performance impact
• Security: ✅ No security concerns
• Test Coverage: ✅ Tests updated appropriately

Conclusion

This is a clean refactoring PR that improves code organization and removes technical debt. The changes are low-risk and follow established patterns. The migration of Datacenter errors to api-util is a sensible consolidation.

Recommendation: ✅ Approve

[pkg-pr-new]

More templates

• actor-actions
• example-ai-agent
• example-ai-and-user-generated-actors-freestyle
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-cloudflare-workers-inline-client
• cross-actor-actions
• example-cursors
• example-cursors-raw-websocket
• custom-serverless
• example-sqlite
• example-elysia
• example-experimental-durable-streams-ai-agent
• hello-world
• example-hono
• hono-react
• example-kitchen-sink
• multi-region
• native-websockets
• next-js
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• scheduling
• state
• example-stream
• example-trpc

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3846

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3846

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3846

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3846

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3846

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3846

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3846

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3846

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3846

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3846

commit: 81663b7