Skip to content

Conversation

@AngelOnFira
Copy link
Contributor

@AngelOnFira AngelOnFira commented Jan 23, 2024

Fixes RVT-3667, closes RVT-3382, closes RVT-3380

BEGIN_COMMIT_OVERRIDE
feat(Main): Added Devcontainer files
END_COMMIT_OVERRIDE

Copy link
Contributor Author

AngelOnFira commented Jan 23, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 23, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@linear
Copy link

linear bot commented Feb 15, 2024

@AngelOnFira AngelOnFira force-pushed the 01-23-Add_devcontainers branch from 5459e53 to 0f2fb89 Compare February 16, 2024 22:38
@linear
Copy link

linear bot commented Feb 20, 2024

@AngelOnFira AngelOnFira force-pushed the 01-23-Add_devcontainers branch 2 times, most recently from 67f6e51 to e435edc Compare February 20, 2024 17:07
@AngelOnFira AngelOnFira marked this pull request as ready for review February 20, 2024 17:08
@linear
Copy link

linear bot commented Feb 20, 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to still test this file on Parsec to make sure it does what it says it does. It might be better to hardcode this, since there are only a few paths that need to be replaced. I'm not the biggest fan of running a rm on someone else's system.

Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo approving this will check it out later

@AngelOnFira AngelOnFira changed the base branch from main to 02-20-Run_cargo_update February 22, 2024 23:28
@AngelOnFira AngelOnFira force-pushed the 01-23-Add_devcontainers branch from e435edc to 461ac65 Compare February 22, 2024 23:28
@AngelOnFira AngelOnFira force-pushed the 01-23-Add_devcontainers branch 2 times, most recently from 332e538 to 32e6778 Compare February 22, 2024 23:48
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 22, 2024

Merge activity

Fixes RVT-3667, closes RVT-3382, closes RVT-3380
@AngelOnFira AngelOnFira force-pushed the 02-20-Run_cargo_update branch from efd0650 to 6c7fa7a Compare February 22, 2024 23:51
@AngelOnFira AngelOnFira force-pushed the 01-23-Add_devcontainers branch from 32e6778 to 9bb97db Compare February 22, 2024 23:52
@AngelOnFira AngelOnFira changed the base branch from 02-20-Run_cargo_update to main February 22, 2024 23:54
@graphite-app graphite-app bot merged commit 9bb97db into main Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants