Skip to content

chore(site): sandbox agent release#4054

Merged
NathanFlurry merged 1 commit intomainfrom
01-28-chore_site_sandbox_agent_release
Jan 28, 2026
Merged

chore(site): sandbox agent release#4054
NathanFlurry merged 1 commit intomainfrom
01-28-chore_site_sandbox_agent_release

Conversation

@NicholasKissel
Copy link
Member

No description provided.

@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4054 January 28, 2026 09:10 Destroyed
@railway-app
Copy link

railway-app bot commented Jan 28, 2026

🚅 Deployed to the rivet-pr-4054 environment in rivet-frontend

Service Status Web Updated (UTC)
website ✅ Success (View Logs) Web Jan 28, 2026 at 10:27 am
mcp-hub ✅ Success (View Logs) Web Jan 28, 2026 at 10:24 am
frontend-inspector 😴 Sleeping (View Logs) Web Jan 28, 2026 at 10:03 am
frontend-cloud 😴 Sleeping (View Logs) Web Jan 28, 2026 at 10:02 am

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 28, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4054

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@4054

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4054

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4054

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4054

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4054

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4054

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4054

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4054

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4054

commit: d75f35a

@claude
Copy link

claude bot commented Jan 28, 2026

PR Review: Sandbox Agent SDK Release

This PR adds website content for the Sandbox Agent SDK launch. Overall the implementation is solid, but there are a few issues to address:

Critical Issues

1. Missing Frontmatter Field (website/src/content/posts/2026-01-28-sandbox-agent-sdk/page.mdx:1-7)

According to CLAUDE.md documentation guidelines, blog posts require specific frontmatter fields. The post is missing the required skill field that is documented for docs pages. However, I notice this is in /content/posts/ not /content/docs/, so this may only apply to docs. Please verify if skill: false or similar is needed for consistency.

2. Mixed Indentation in Code Example (page.mdx:100)

The code example mixes tabs and spaces. Line 100 uses a tab for the comment, while line 101 uses spaces. Per CLAUDE.md, Rust uses hard tabs, but this is TypeScript. For consistency and to avoid confusing readers, use consistent indentation (preferably spaces for TypeScript examples).

Code Quality Issues

3. Incomplete Tabs Component (page.mdx:157)

The MDX uses <Tabs> and <Tab> components without importing them. Verify these components are globally available in your MDX setup, or add the necessary imports at the top of the file.

4. Missing Import in React Example (page.mdx:188)

The React example uses useState without importing it. Should add: import { useState } from "react";

Style & Best Practices

5. Inconsistent Link Styling

The new "Sandbox Agent SDK" links use different URL formats:

  • Footer: https://sandboxagent.dev (no trailing slash)
  • Header v1: https://sandboxagent.dev (no trailing slash)
  • Header v2: https://sandboxagent.dev/ (trailing slash)

Choose one format for consistency. I recommend no trailing slash for the root domain.

6. Accessibility: Missing ARIA Labels (Header.jsx:194, v2/Header.tsx:70)

The "Products" dropdown buttons lack accessible labels for screen readers. Consider adding aria-label="Products menu".

7. Comment Style Deviation (page.mdx:100, 110, 138)

Per CLAUDE.md guidelines on comments: "Write comments as normal, complete sentences." The inline comments in the code examples are acceptable but could be more complete sentences.

Positive Observations

Good SVG Assets: The product logos are clean and properly formatted with viewBox for scalability.

Comprehensive Documentation: The blog post provides excellent coverage of the SDK features with practical code examples.

Consistent Dropdown Pattern: The new Products dropdown follows the same implementation pattern as the existing Solutions dropdown, making the codebase more maintainable.

Proper External Link Handling: External links correctly use target="_blank" and rel="noopener noreferrer" for security.

Responsive Design: Both desktop and mobile navigation implementations are included with consistent feature parity.

Recommendations

  1. Fix the mixed indentation in the code example (critical for reader clarity)
  2. Add missing React import for useState
  3. Standardize trailing slashes in URLs
  4. Verify Tabs component availability or add imports
  5. Consider adding ARIA labels for better accessibility
  6. Verify frontmatter requirements for blog posts vs docs

Security & Performance

No security concerns identified. All external links properly use rel="noopener noreferrer". The dropdown implementation uses proper event handling to prevent memory leaks (cleanup in useEffect).

Test Coverage

This PR is primarily content and UI changes. Consider adding:

  • Visual regression tests for the new dropdown menu
  • Link validation tests to ensure sandboxagent.dev is reachable
  • Mobile navigation tests for the Products dropdown

Overall Assessment: Approve with minor fixes needed. The mixed indentation and missing import should be corrected before merge. The other issues are nice-to-haves that can be addressed in follow-up PRs if needed.

@NathanFlurry NathanFlurry force-pushed the 01-28-chore_site_sandbox_agent_release branch from 7975427 to d75f35a Compare January 28, 2026 10:23
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4054 January 28, 2026 10:23 Destroyed
@NathanFlurry NathanFlurry marked this pull request as ready for review January 28, 2026 10:28
@NathanFlurry NathanFlurry merged commit 13de212 into main Jan 28, 2026
12 of 20 checks passed
@NathanFlurry NathanFlurry deleted the 01-28-chore_site_sandbox_agent_release branch January 28, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants