feat(sentry): use correct env#4149
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Code ReviewThis PR adds proper Sentry environment configuration to distinguish between staging and production environments. Overall, the changes are straightforward and improve observability. Here are my findings: ✅ Positives
🐛 Issues Found1. Missing import in components package (frontend/packages/components/src/third-party-providers.tsx:39)The file references // Missing import - need to add:
import { commonEnv } from '@/lib/env';
// Or equivalent relative path2. Duplicate/leftover code removed (frontend/packages/components/src/third-party-providers.tsx:46)Good catch removing the duplicate 3. Console.log in production code (frontend/vite.engine.config.ts:36-39)The added console.log is useful for debugging but should probably use a proper logging mechanism or be removed before merging to production: console.log(
env.SENTRY_AUTH_TOKEN
? "Sentry plugin enabled"
: "Sentry plugin disabled (missing auth token)",
);Consider: Is this intended for debugging only, or should it stay? If keeping it, consider using a conditional based on environment. 📝 Minor Observations
🧪 Testing RecommendationsBefore merging:
🔒 SecurityNo security concerns - Sentry DSN and environment names are public-facing values that are safe to include in client-side code. ⚡ PerformanceNo performance impact. Summary: The PR is solid conceptually but has a critical import issue that will break the build. Fix the missing Recommendation: Request changes to fix the import error before merging. |
Graphite Automations"Test" took an action on this PR • (02/06/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
7e97d88 to
b392e46
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: