refactor(inspector): separate inspector app from dashboard#4227
Conversation
|
🚅 Deployed to the rivet-pr-4227 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Test" took an action on this PR • (02/18/26)1 assignee was added to this PR based on Kacper Wojciechowski's automation. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -0,0 +1 @@ | |||
| /Users/kwojciechowski/Documents/Projects/rivet.gg/rivet/frontend/public No newline at end of file | |||
There was a problem hiding this comment.
This file contains an absolute path to a local machine (/Users/kwojciechowski/Documents/Projects/rivet.gg/rivet/frontend/public). This will break for:
- Other developers checking out the code
- CI/CD pipelines
- Production deployments
Fix: Use a relative path for the symlink instead:
ln -s ../../public frontend/apps/inspector/publicOr configure the build tool to handle the public directory appropriately rather than committing a symlink.
| /Users/kwojciechowski/Documents/Projects/rivet.gg/rivet/frontend/public | |
| ../../public | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
PR Review: refactor(inspector): separate inspector app from dashboardThe overall direction of this refactor is sound — separating the Inspector into its own standalone app improves separation of concerns and makes each app independently configurable. Here are the issues I found: CriticalBroken absolute symlink committed to the repo
This is a developer's local machine path and will be broken in every other environment (CI, other contributors, production builds). Replace this with a relative symlink (e.g., BugsDisconnected state calls In // status === "disconnected"
<Button onClick={() => disconnect()}> // should reconnect, not disconnect
<Icon icon={faLink} />
</Button>The tooltip says "Reconnect" but the action disconnects further. This needs a Modal enum mismatch in The search schema modal enum in modal: z.enum(["go-to-actor", "feedback", "create-ns", "create-project", "billing"])
.or(z.string()).optional()But the Code QualityHTTP instead of HTTPS for external links
<a href="http://www.rivet.dev/discord" ...>Discord</a>
<a href="http://github.com/rivet-dev/rivet" ...>GitHub</a>These should use Deprecated domain in alt text
Typo: missing apostrophe
Trailing whitespace in className strings Several className values have a leading space that could be cleaned up (minor):
MinorMissing No
The file now re-exports from What's working well
The symlink issue should be fixed before merge as it will break CI/builds for anyone else on the team. |
1 participant
Description
Created a dedicated Inspector app in the frontend directory structure. This change moves the Inspector functionality from being embedded in the main frontend application to its own standalone app, allowing for better separation of concerns and more focused development.
The new Inspector app includes:
This refactoring removes Inspector-related code from the main frontend codebase, including context providers, routes, and UI components that were previously shared.
Type of change
How Has This Been Tested?
The Inspector app has been tested by verifying it can:
Checklist: